Re: [SCM] GNU Autoconf source repository branch, master, updated. v2.63-197-g291d709

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Eric Blake on 11/16/2008 2:30 PM:
> According to Ralf Wildenhues on 11/16/2008 2:18 PM:
>> @@ -1743,6 +1743,7 @@ 
>> AS_IF([_AS_RUN(["AS_ESCAPE(m4_quote(_AS_VAR_ARITH_WORKS))"])],
>>  [as_func_arith ()
>>    {
>>      as_val=`expr "$[]@"`
>> +    case $? in 0|1) :;; *) false;; esac
> 
> Apologies for not reviewing this closer.  m4_quote doesn't like the
> unbalanced unquoted ) you just introduced into _AS_VAR_ARITH_WORKS.  You
> need to either change that _AS_RUN to use m4_expand (which handles
> unbalanced unquoted paren), or write [)] (so the parens are quoted), or
> add balancing ( as a shell comment.

On the other hand, the unbalanced unquoted ) you introduced was within
_AS_VAR_ARITH_PREPARE as an argument of AS_IF (which happens to handle
this use case), not _AS_VAR_ARITH_WORKS.  But I'd still be more
comfortable if we patched this to be more robust, if only so we are in the
habit of properly quoting or balancing parens for where it matters.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkkgk7QACgkQ84KuGfSFAYDA2ACcCH5L4k/2qcWpXWPoBsYwE0Fa
WVUAn19h/aTjiifGEHhTjhYFec7r+lQt
=BXY7
-----END PGP SIGNATURE-----