[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: shell function for AS_ERROR
From: |
Paolo Bonzini |
Subject: |
Re: shell function for AS_ERROR |
Date: |
Fri, 21 Nov 2008 21:23:23 +0100 |
User-agent: |
Thunderbird 2.0.0.18 (Macintosh/20081105) |
Eric Blake wrote:
> My recent patches to AS_EXIT actually bulked up the size of configure
> scripts,
> thanks to the use of $as_status when AS_ERROR is used without a second
> argument
> (which is most of the time). What do you think of this patch for trimming
> things back down?
Good!
> I checked that bin/autoconf, tests/testsuite, and configure
> all get the correct number and location of as_fn_error definitions (and it
> wasn't very easy, since I intentionally made the shell function definition
> dependent on whether logging is in use, so that bin/autoconf's version is
> lighter-weight than configure's version).
I appreciate the effort, but is this really necessary? How much do you
save?
Paolo
ps: I did read the patch. :-)