[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: avoid spurious failures from MacOS readdir bug
From: |
Paolo Bonzini |
Subject: |
Re: avoid spurious failures from MacOS readdir bug |
Date: |
Sat, 06 Dec 2008 07:35:34 +0100 |
User-agent: |
Thunderbird 2.0.0.18 (Macintosh/20081105) |
Eric Blake wrote:
> According to Eric Blake on 12/2/2008 6:03 PM:
>> $ grep AC_STATE_SAVE\( tests/testsuite | wc -l
>> 591
>
>> Of which, many instances are inside generated configure.ac files where the
>> testsuite then runs the configure script multiple times. So shaving a
>> process here shaves more than 1000 forks off the total testsuite time,
>> with a noticeable impact on cygwin.
>
> I went ahead and applied the patch, after further testing that Solaris and
> BSD sed behaved correctly.
Indeed, they shouldn't have problems because their line length limit is
~4000 (giving a maximum length of ~2000 bytes for files in the
directory, which is safe). However, note that the script is emulating
uniq, not sort -u. I don't know if this is safe?
Paolo