Re: [PATCH 2/5] docs: mention cost of globbing during variable expansion

[Eric Blake]

On 08/26/2010 11:29 AM, Ralf Wildenhues wrote:
> >   @example
> > -: address@hidden"$default"@}
> > +: "address@hidden"$default"@}"
> >   @end example
> >
> >   @item
>
> ... it doesn't look to safe to change code snippets in the manual that
> describe quoting bugs in old shells, which is true for at least some of
> the above.  I don't know if you've fixed all instances in followup
> patches already, but at least I haven't seen a log entry that states
> this.

Agreed; I think I reverted all of these changes eventually (since 
without having the old system to verify with, I can't be sure that the 
"" version would even trigger the bug under discussion).

> >   # Provide a safe default value.
> > -: ${ac_cv_func_select_args='int,int *,struct timeval *'}
> > +: "${ac_cv_func_select_args='int,int *,struct timeval *'}"
>
> This one looks buggy too (and is not reverted yet).

Indeed - I'll fix it now.

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org