Re: [PATCH] tests: skip broken automake wrapper on MirBSD

[Eric Blake]

On 09/13/2010 10:20 AM, Stefano Lattarini wrote:
> Hi Eric.  Just a little nitpicking...
>
> On Monday 13 September 2010, Eric Blake wrote:
> > diff --git a/tests/tools.at b/tests/tools.at
> > index 167d68a..e4e119b 100644
> > --- a/tests/tools.at
> > +++ b/tests/tools.at
> > @@ -1164,8 +1164,9 @@ AT_SETUP([autom4te preselections])
> >   # If this test should run on FAT file systems and older w32,
> >   # then setting $sleep correctly needs to be revisited.
> >
> > -# We use aclocal and automake.
> > -AT_CHECK([automake --version || exit 77], [], [ignore], [ignore])
> > +# We use aclocal and automake.  Skip broken automake wrappers.
> > +AT_CHECK([automake --version || exit 77], [], [stdout], [ignore])
> > +AT_CHECK([[grep '[1-9]\.[0-9][0-9]*' stdout || exit 77]], [],
> Wouldn't "grep '[1-9]\.[0-9]'" be enough here?  Ditto for the other
> occurrences in the patch.

Hmm, yeah.  The current version is harmless, but a patch to use the 
shorter regex won't hurt, either.  Do you want to write it?

--
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org