[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] Modernize header checks, v2
From: |
Paul Eggert |
Subject: |
Re: [PATCH 0/3] Modernize header checks, v2 |
Date: |
Sat, 07 Sep 2013 07:06:17 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 |
Zack Weinberg wrote:
> One remaining wart is that autoupdate
> replaces AC_HEADER_STDC with an overt invocation of
> _AC_INCLUDES_DEFAULT_REQUIREMENTS. I couldn't find an AU_DEFUN
> construct that didn't expose this internal macro but would still DTRT
> both before and after an autoupdate run. Ideas?
Perhaps we should make that macro public, under the name
AC_INCLUDES_DEFAULT_REQUIREMENTS. It does seem weird
to inject _AC_* stuff into user code.
The other changes you're making all sound reasonable,
though I haven't reviewed the code. Unless someone
objects soon I think they should be installed. Would
you like to do that? I see two Zack Weinbergs zackw
and zwol at Savannah, but neither have checkin rights,
so I'm not sure what's going on there.