[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: RFC PATCH: Overhaul AC_TYPE_GETGROUPS and AC_FUNC_GETGROUPS.
|
From: |
Zack Weinberg |
|
Subject: |
Re: RFC PATCH: Overhaul AC_TYPE_GETGROUPS and AC_FUNC_GETGROUPS. |
|
Date: |
Sun, 02 Apr 2023 21:30:17 -0400 |
|
User-agent: |
Cyrus-JMAP/3.9.0-alpha0-238-g746678b8b6-fm-20230329.001-g746678b8 |
On Sun, Apr 2, 2023, at 5:36 PM, Paul Eggert wrote:
> That error case is not very important, since programs are not likely
> to exercise it. The really serious failures are for long-dead systems
> (Ultrix 4.3, NextSTEP 3.2) that we no longer need to worry about.
>
> AC_FUNC_GETGROUPS has been documented as being obsolescent since
> Autoconf 2.70 (2020). I think changing it to report a failure on macOS
> and FreeBSD is more likely to cause problems than cure them.
Yeah, on reflection I agree with that.
My goal here is to get rid of all internal uses of AC_EGREP_CPP and
AC_EGREP_HEADER. I don't think we should aggressively add to the
list of -Wobsolete warnings in what's supposed to be a bugfix release.
Therefore, how about I revise this patch to remove the case for
freebsd* | darwin*, and make no other changes?
zw