[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] Fix detection of GNU M4 on mksh
|
From: |
KO Myung-Hun |
|
Subject: |
Re: [PATCH 1/2] Fix detection of GNU M4 on mksh |
|
Date: |
Sun, 15 Oct 2023 15:58:47 +0900 |
|
User-agent: |
Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2 |
Hi/2.
Zack Weinberg wrote:
> On Sat, Oct 14, 2023, at 9:19 AM, KO Myung-Hun wrote:
>> * m4/m4.m4 (AC_PROG_GNU_M4): Double-quotes $ac_snip2.
>
> Please explain why it isn't also necessary to add double quotes
> around all the other variable expansions in this check, particularly
> $ac_snippet and $ac_path_M4.
>
Because this test fails due to $ac_snip2. Anyway I've double-quoted
$ac_snippet, too.
However, not required to $ac_path_M4, which does not contain NL.
> Also, typo in your commit message: "Double-quotes" should be "Double-quote".
>
Fixed.
--
KO Myung-Hun
Korean OS/2 User Community : https://www.os2.kr/
v2-0001-Fix-detection-of-GNU-M4-on-mksh.patch
Description: Source code patch
- Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2, (continued)
- Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2, KO Myung-Hun, 2023/10/15
- Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2, Zack Weinberg, 2023/10/17
- Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2, Paul Eggert, 2023/10/17
- Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2, Zack Weinberg, 2023/10/18
- Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2, KO Myung-Hun, 2023/10/18
- Re: [PATCH 2/2] Ignore failure of setting mode on a temporary file on OS/2, Zack Weinberg, 2023/10/18
[PATCH 1/2] Fix detection of GNU M4 on mksh, KO Myung-Hun, 2023/10/14