automake-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[automake-commit] branch master updated: doc: comment Vala -newer test.


From: Karl Berry
Subject: [automake-commit] branch master updated: doc: comment Vala -newer test.
Date: Sat, 05 Dec 2020 21:19:29 -0500

This is an automated email from the git hooks/post-receive script.

karl pushed a commit to branch master
in repository automake.

View the commit online:
https://git.savannah.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=46420770f96f77b0ca0be8a90919ba2378415481

The following commit(s) were added to refs/heads/master by this push:
     new 4642077  doc: comment Vala -newer test.
4642077 is described below

commit 46420770f96f77b0ca0be8a90919ba2378415481
Author: Karl Berry <karl@freefriends.org>
AuthorDate: Sat Dec 5 18:19:18 2020 -0800

    doc: comment Vala -newer test.
    
    This change updates https://bugs.gnu.org/44772.
    
    * bin/automake.in (lang_vala_finish_target): comment that
    we're checking "C file not older than Vala file", and the
    log message misleadingly says "reversed".
---
 bin/automake.in | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/bin/automake.in b/bin/automake.in
index 96e8c63..8edd0c7 100644
--- a/bin/automake.in
+++ b/bin/automake.in
@@ -5738,6 +5738,12 @@ sub lang_vala_finish_target
           my $built_c_file = "\$(builddir)/$c_file";
           my $built_dir = dirname $built_c_file;
           my $base_c_file = basename $c_file;
+          #
+          # The -newer test here is checking "C file not older than Vala
+          # file" (not "C file newer than Vala file"; see
+          # https://bugs.gnu.org/44772. The log message on the commit
+          # misleadingly says "reversed".
+          #
           $output_rules .= "$built_c_file: 
\$(builddir)/${derived}_vala.stamp\n"
             . "\t\@if test ! -f \$@ && test \$(srcdir) != \$(builddir) && test 
-n \"\$\$(find -L \$(srcdir)/$vala_file -prune \! -newer \$(srcdir)/$c_file)\"; 
then cp -p \$(srcdir)/$c_file $built_c_file; fi\n"
             . "\t\@if test -f \$@; then :; else rm -f 
\$(builddir)/${derived}_vala.stamp; fi\n"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]