automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Automake-ng] [FYI] [ng] build: simplify rules for ChangeLog generation


From: Stefano Lattarini
Subject: [Automake-ng] [FYI] [ng] build: simplify rules for ChangeLog generation
Date: Mon, 16 Apr 2012 14:21:42 +0200

The pre-existing rules used an hacky indirection, only to work
around a Solaris make bug in '.PHONY' support.  GNU make does
not suffer of this bug, so we can simplify our rules accordingly.

* Makefile.am (am--changelog-regen-hook): Remove this dummy target.
(.PHONY, ChangeLog): Do not depend on it.
(.PHONY): Depend directly on 'ChangeLog' instead.
Remove outdated comments.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 Makefile.am |   11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index 6b5695c..8c29aee 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -595,15 +595,8 @@ EXTRA_DIST += $(gitlog_to_changelog_fixes)
 # copy the distributed ChangeLog in the build directory (and if this
 # fails, or if no distributed ChangeLog file is present, complain and
 # give an error).
-#
-# We need the apparently useless dependency from another .PHONY target
-# 'am--changelog-regen-hook' to work around a bug of Solaris make, which
-# doesn't execute the recipe of a target named as an existing file, even
-# if such target is declared '.PHONY' (yikes!)
-#
-.PHONY: am--changelog-regen-hook
-am--changelog-regen-hook:
-ChangeLog: am--changelog-regen-hook
+.PHONY: ChangeLog
+ChangeLog:
        $(AM_V_GEN)set -e; set -u; \
 ## The ChangeLog should be regenerated unconditionally when working from
 ## checked-out sources; otherwise, if we're working from a distribution
-- 
1.7.9.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]