Re: [Automake-NG] [PATCH 00/11] Several changes to parallel-tests support

[Akim Demaille]

Le 9 mai 2012 à 11:30, Stefano Lattarini a écrit :

> I will push in 72 hours if there is no review by then.

I browsed them all.  I'm happy that it will be possible to
specify dependencies :)

It looks ok, and very cleanly done.

I have one worry though: what about runtime performances?  Sure,
late binding provides more features, but it might be costly.  Do
you have means to evaluate that we have no serious regressions?

Also, I don't know if it's part of your specs for automake-ng,
but, performance-wise *and* from the point of view of semantics,
*and* of syntax, I am very fond of this new feature of GNU Make 3.82:

* New special target: .ONESHELL instructs make to invoke a single instance
  of the shell and provide it with the entire recipe, regardless of how many
  lines it contains.  As a special feature to allow more straightforward
  conversion of makefiles to use .ONESHELL, any recipe line control
  characters ('@', '+', or '-') will be removed from the second and
  subsequent recipe lines.  This happens _only_ if the SHELL value is deemed
  to be a standard POSIX-style shell.  If not, then no interior line control
  characters are removed (as they may be part of the scripting language used
  with the alternate SHELL).

I would strongly suggest to use it, and to drop \ and ; as dead as can be
(before my keys are completely worn out).

.ONESHELL:
all:
        @foo=bar
        echo $$foo
        if test $$foo = bar; then
          echo pass
        else
          echo fail
        fi


$ gmake -C /tmp
gmake : on entre dans le répertoire « /private/tmp »
bar
pass
gmake: on quitte le répertoire « /private/tmp »