Re: [Automake-NG] [PATCH 0/4] Prefer pattern rules over suffix rules

[Stefano Lattarini]

Hi Akim.

On 05/10/2012 02:43 PM, Akim Demaille wrote:
> 
> Le 10 mai 2012 à 14:29, Stefano Lattarini a écrit :
> 
>> As usual, I will push to 'ng/master' in 72 hours if there is no
>> review by then.
> 
> All this seems, with a quick reading, fine.  I'm sorry
> to see how often the test suite needs major surgery,
> it must account for a large amount of your hacking
> time.
>
Well, if you had followed the Automake developement in the last couple
of years, you'd see that I had brought this upon myself :-)

On a more serious note: I don't mind tweaking the testsuite, if the
extra coverage it offers helps me to:

  1. ensure I don't introduce regressions nor unintended behavioural
     changes, and

  2. better understand what the code I'm modifying is supposed to
     accomplish.

In the present case, the testsuite has helped me with both those
aspects, so I didn't mind the extra time necessary to tweak it.
After all, TANSTAAFL ;-)

> There is a minor issue with foo_SOURCES indentation in NEWS.
> 
Well spotted, I've fixed it now.  I will soon push the series if there
are no further observations nor objections.

Thanks,
  Stefano