[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-NG] [Automake-ng] [PATCH 0/4] Minor refactoring and cleanu
From: |
Stefano Lattarini |
Subject: |
Re: [Automake-NG] [Automake-ng] [PATCH 0/4] Minor refactoring and cleanup for the dist-related targets |
Date: |
Thu, 10 May 2012 18:24:21 +0200 |
Hi Jim, automakers.
On 05/06/2012 08:25 PM, Jim Meyering wrote:
> Stefano Lattarini wrote:
>> These changes don't offer great simplifications nor optimizations, but
>> move some logic from automake execution time and recipe execution
>> time to make runtime, and clean up some old namespace pollution and API
>> leakiness -- which is the general direction Automake-NG should be moving
>> along IMHO.
>>
>> So, ACK for this? I will push in 72 hours if there is no objection, but
>> I'd like a review before then if possible.
>
> Hi Stefano,
>
> I like the ideas and skimmed through the patches (they look fine), but
> did not apply or test.
>
I've now made some simple performance tests on the series.
I have configured a tree with 5000 files in EXTRA_DIST at the top-level,
and 5000 more files in EXTRA_DIST in a $(SUBDIR). On my slowish Debian
system:
* "make all" run 100 times in a row
(before the series): ~ 25 seconds
(before the series): ~ 26 seconds
* "make distdir --dry-run" run 100 times in a row
(before the series): ~ 1 minute
(before the series): ~ 1 minute and a half
* "make distdir" run 10 times in a row
(before the series): ~ 5 minutes and 50 seconds
(before the series): ~ 6 minutes and 15 seconds
All in all, good enough I think. I will push by this evening if there is
no further comment.
Regards,
Stefano
- [Automake-ng] [PATCH 0/4] Minor refactoring and cleanup for the dist-related targets, Stefano Lattarini, 2012/05/06
- [Automake-ng] [PATCH 2/4] [ng] dist: strip duplicates from dist files at make (not automake) runtime, Stefano Lattarini, 2012/05/06
- [Automake-ng] [PATCH 1/4] [ng] dist: simplify VPATH handling, Stefano Lattarini, 2012/05/06
- [Automake-ng] [PATCH 4/4] [ng] dist: optimize calculation of list of distributed file, Stefano Lattarini, 2012/05/06
- [Automake-ng] [PATCH 3/4] [ng] dist: rename some non-public vars to make clear they are internal, Stefano Lattarini, 2012/05/06
- Re: [Automake-ng] [PATCH 0/4] Minor refactoring and cleanup for the dist-related targets, Jim Meyering, 2012/05/06
- Re: [Automake-NG] [Automake-ng] [PATCH 0/4] Minor refactoring and cleanup for the dist-related targets, Bob Friesenhahn, 2012/05/10
- Re: [Automake-NG] [Automake-ng] [PATCH 0/4] Minor refactoring and cleanup for the dist-related targets, Stefano Lattarini, 2012/05/10