Re: [Automake-NG] [PATCH 00/15] Simplify and refacotor variable handling a bit

[Stefano Lattarini]

On 05/25/2012 01:38 PM, Stefano Lattarini wrote:
> Far from the sweeping simplifications I was hoping for when I started
> writing this series, but they are good to go IMHO.  A better cleanup
> (which I still hope I'll be able to do eventually) will probably require
> a rewrite of the Automake::Variable and Automake::VarDef modules :-/
> 
> OK for ng/master?  I will push in a couple of days if there is no
> objection.
> 
> Regards,
>   Stefano
> 
> -*-*-
>
I've now pushed this series, after dropping ...

> Stefano Lattarini (15):
>   [ng] cleanup: remove unused private variables in Automake::Variable
>   [ng] vars: get rid of VAR_SORTED type
>   [ng] vars: get rid of VAR_SILENT type
>   [ng] tests: spy behaviour of '+=' with GNU make
>   [ng] tests: Automake should let us append to undefined variables (someday)
>   [ng] refactor: support comments only for VarDef, not for ItemDef too
>   [ng] VarDef: store comments and values as a perl array
>   [ng] vars: simplify logic for appending conditionally
>   [ng] vars: keep track of conditionals in appended values and comments
>   [ng] vars: get rid of VAR_ASIS / VAR_PRETTY distinction
>   [ng] refactor: change signature of 'define_variable()'
>   [ng] cleanup: prefer 'define_variable' over 'define_pretty_variable'
>   [ng] rename: define_pretty_variable -> define_cond_variable()
>   [ng] cosmetics: avoid redundant use of '&' in subroutine calls
>
>   [ng] vars: remove some safety checks in Automake::Variable::define
>
... this last patch, because its only purpose would be to simplify
future refactorings, which are still not ready nor truly planned.

I've also pushed the attached patch as a follow-up, to fix a regression
revealed by the more comprehensive tests in 'ng/master'.

Regards,
  Stefano

0001-ng-vars-recognize-escaped-correctly-in-a-variable-de.patch
Description: Text Data