Re: [Automake-NG] [PATCH 2/6] [ng] parallel-tests: do not exceed command line length limits

[Akim Demaille]

Le 21 juil. 2012 à 10:50, Stefano Lattarini a écrit :

> Fixes automake bug#7868.
> 
> Two things worth noting:
> 
> + a "make recheck" issued after a huge number of tests have failed
>   can still hit command-line length issues;
> 
> + the check-recipes now contain (first among the Automake-generated
>   recipes) a use of the 'xargs' utility.
> 
> These issues will likely be tackled by later patches.
> 
> * Makefile.am (XFAIL_TESTS): Remove 't/parallel-tests-many.sh'.
> * lib/am/clean.am (.am.clean-cmd.f, .am.clean-cmd.d, .am.rm-f,
> .am.rm-rf): Moved their definitions …

Move

> * lib/am/header-vars.am: ... here, because we need to use them ...
> * lib/am/parallel-tests.am: ... here as well.
> (am.test-harness.workdir, am.setup-test-harness-workdir,
> am.test-harness.append-to-list-of-bases): New internal variables.
> Use them to avoid hitting command-line length limits ...
> ($(TEST_SUITE_LOG), recheck): ... in this rules ...
> (am__remove_if_not_lazy_check): ... and in the shell code defined
> by this internal variable.

> +       while read b; do echo $$b; done <$$workdir/bases              \
>           | $(am__create_global_log);                                 \

What is the point of the loop?

< $$workdir/bases $(am__create_global_log)

Similarly elsewhere.