Re: [Automake-NG] [PATCH] [ng] serial-tests: remove one level of indentation in a recipe

[Stefano Lattarini]

On 07/30/2012 09:24 AM, Akim Demaille wrote:
> 
> Le 28 juil. 2012 à 13:10, Stefano Lattarini a écrit :
> 
>>      test -z "$$skipped" || echo "$${col}$$skipped$${std}"; \
>>      test -z "$$report" || echo "$${col}$$report$${std}"; \
>>      echo "$${col}$$dashes$${std}"; \
>> -      test "$$failed" -eq 0; \
>> -    else :; fi
>> +    test "$$failed" -eq 0 || exit 1
> 
> It looks like the "|| exit 1" are useless.
>
Almost surely yes, but we've had issues with wrong exit statuses for the 
testsuite
harness in the past, causing reports of success when the actual result was a 
failure
(see http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9245) and while that 
admittedly
happened only with non-GNU makes, I'd still rather err on the side of safety.

>> +    echo "$${col}$$dashes$${std}"; \
>> +    test "$$failed" -eq 0 || exit 1
>> -- 
>> 1.7.12.rc0
>>

Thanks,
  Stefano