[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 46-formatting-changes.patch
From: |
Tom Tromey |
Subject: |
Re: 46-formatting-changes.patch |
Date: |
21 Feb 2001 15:37:02 -0700 |
>>>>> "Akim" == Akim Demaille <address@hidden> writes:
Akim> * automake.in: Formatting changes.
Please say something like "Use my instead of local", since this goes
beyond mere formatting.
Akim> - local ($sect, %sections, %vlist);
Akim> + local (%sections, %vlist);
I think the new standard should be that we use `my' everywhere and
never use `local'. I only used local in the first place because Perl
4 didn't have `my'. I tried very hard to write code so that we could
eventually s/local/my/, as you are doing, since lexical scoping is
just better than dynamic scoping.
If you need to keep local here for now that is fine. But if so please
add a big comment explaining why.
Ignore this if this spot is fixed in a later patch. I'm reading and
responding in order this time.
This is ok.
Tom