avr-libc-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [avr-libc-dev] twi.h move


From: Eric Weddington
Subject: Re: [avr-libc-dev] twi.h move
Date: Sun, 11 Sep 2005 15:28:03 -0600
User-agent: Mozilla Thunderbird 1.0 (Windows/20041206)

Joerg Wunsch wrote:

I just came across this old mail from Ted:

As Theodore A. Roth wrote:


Regardless of the validity of making the move, the file in include/avr
should have had a place holder left which simply included the compat
file and issued a deprecation warning like we did when migrating files
down into the include/avr directory.

I wonder whether it would be wise to move it back, and leave
compat/twi.h as a placeholder (including <avr/twi.h>) only.  I feel I
did rush that removal before 1.2 too much, only relying on that being
mentioned on an old TODO list (without even agreeing to the change
myself, I might add).

Well, now this brings up our recent discussion about policy. If we follow it, <compat/*> is only for compatibility: compability with other compilers, or backwards compatibility.

The TWI is an on-board peripheral of the AVR and as such, I would say that it should go in <avr/twi.h>.

Would this be correct policy?

IIRC, the header file just contained some #defined values. Of course, it would make sense to eventually add an API of some sort to provide more functionality, but that can be done later down the road.

Any thoughts?

Eric





reply via email to

[Prev in Thread] Current Thread [Next in Thread]