[avrdude-dev] [patch #7703] AT89S5x support, stk500 spi frequency bugfix, other minor fixes

[Joerg Wunsch]

Follow-up Comment #1, patch #7703 (project avrdude):

I'm happy with about everything you are telling, except one:

> I tend to set my editor to strip extra spaces from line
> ends and convert tabs to spaces; sorry.

There's one general rule:

Don't mess with other people's style.  Style changes easily
obfuscate actual code changes in the version history, and
thus make it hard to track down bugs later on.

If you really have to mess with it, strictly separate the
style-only changes from actual code changes, so both can be
separated in _two_ commits.

No, your editor's preferences don't serve as an excuse here.  My
editor's preferences frequently don't match the files' style here
either (and AVRDUDE's files, unfortunately, don't follow a consistent
style at all), so I have to adjust my editor settings anew for each
file, so resulting changes will follow the existing style in the file
I'm working on as best as possible.


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7703>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/