[avrdude-dev] [patch #7718] Merge global data of avrftdi in a private data structure

[Hannes Weisbach]

URL:
  <http://savannah.nongnu.org/patch/?7718>

                 Summary: Merge global data of avrftdi in a private data
structure
                 Project: AVR Downloader/UploaDEr
            Submitted by: hweisbach
            Submitted on: So 05 Feb 2012 10:52:43 GMT
                Category: None
                Priority: 7 - High
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

avrftdi has a lot of static variables and someone (Joerg, I believe) expressed
the whish those variables should be merged into a private data structure
attached to the PROGRAMMER data structure.

This is what the attached patch accomplishes. I tested it with my 4232H and
2232C on OS X 10.6.8. Because the patch is rather big I think it's a good idea
if someone tests it on Linux and *BSD.

The patch also fixes an programming mistake, where in avrftdi_open()
write_flush() - and hence ftdi_write_data() is called before
ftdi_set_bitmode().
ftdi_write_data() sends MPSSE commands, but the interface is not yet in MPSSE
mode.

I had the problem that the FTDI reported bad opcodes (returns 0xfa) and was
out of sync. Since the change, everything seems fine.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: So 05 Feb 2012 10:52:43 GMT  Name: avrftdi_pdata.patch  Size: 19kB   By:
hweisbach

<http://savannah.nongnu.org/patch/download.php?file_id=24984>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?7718>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/