[avrdude-dev] [patch #8436] Remove HAVE_STDINT_H guards in flip1.c and flip2.c

[Joerg Wunsch]

Update of patch #8436 (project avrdude):

                  Status:                    None => Need Info              

    _______________________________________________________

Follow-up Comment #1:

I cannot confirm your statement #1: it compiles fine the way
it is in my MinGW32 cross-compilation environment.

Regarding reasoning #2, I don't see we are consistent in
either direction:

. libavrdude.h checks for HAVE_STDINT_H, and acts correctly
  upon it
. fileio.c and ft245.c use <stdint.h> unchecked
. flip1/2 checks for either symbol, and acts upon it

IMHO, it would make most sense to remove *all* the checks
(including the one in libavrdude.h), and then assume <stdint.h>
always being present.  AVRDUDE assumes a C99 compatible
environment in many other places already anyway.

Would you be willing to resubmit a patch that unifies it that
way?

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?8436>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/