[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #60753] Patch #1436 breaks multiple programmer/device combinations
From: |
Joerg Wunsch |
Subject: |
[bug #60753] Patch #1436 breaks multiple programmer/device combinations on MacOS BigSur |
Date: |
Fri, 25 Jun 2021 00:51:21 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; FreeBSD amd64; rv:84.0) Gecko/20100101 Firefox/84.0 |
Update of bug #60753 (project avrdude):
Status: None => Confirmed
Assigned to: None => joerg_wunsch
_______________________________________________________
Follow-up Comment #2:
I suggest comparing against mem->page_size > 1 instead, since this is
basically identical in behaviour to the pre-#1436 behaviour.
Also, there are more occasions than just line 364.
Please test the following patch.
+++
Index: avr.c
===================================================================
--- avr.c (revision 1450)
+++ avr.c (working copy)
@@ -330,7 +330,7 @@
memset(mem->buf, 0xff, mem->size);
/* supports "paged load" thru post-increment */
- if ((p->flags & AVRPART_HAS_TPI) && mem->page_size != 0 &&
+ if ((p->flags & AVRPART_HAS_TPI) && mem->page_size > 1 &&
pgm->cmd_tpi != NULL) {
while (avr_tpi_poll_nvmbsy(pgm));
@@ -361,7 +361,7 @@
return avr_mem_hiaddr(mem);
}
- if (pgm->paged_load != NULL && mem->page_size != 0) {
+ if (pgm->paged_load != NULL && mem->page_size > 1) {
/*
* the programmer supports a paged mode read
*/
@@ -863,7 +863,7 @@
}
- if ((p->flags & AVRPART_HAS_TPI) && m->page_size != 0 &&
+ if ((p->flags & AVRPART_HAS_TPI) && m->page_size > 1 &&
pgm->cmd_tpi != NULL) {
while (avr_tpi_poll_nvmbsy(pgm));
@@ -903,7 +903,7 @@
return i;
}
- if (pgm->paged_write != NULL && m->page_size != 0) {
+ if (pgm->paged_write != NULL && m->page_size > 1) {
/*
* the programmer supports a paged mode write
*/
---
_______________________________________________________
Reply to this item at:
<https://savannah.nongnu.org/bugs/?60753>
_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/