Re: [Bino-list] [PATCH] restore and save geometry of the MainWindow

[Martin Lambers]

On 08/10/11 19:54, Daniel Schaal wrote:
> Am Samstag, 8. Oktober 2011, 19:12:40 schrieb Martin Lambers:
>> On 08/10/11 13:53, Daniel Schaal wrote:
>>> Attached is a patch to save and restore the geometry and state of the
>>> MainWindow.
>>
>> Hm, I don't know if we should apply this patch. Bino changes its size
>> when opening a new video file (like most players do), so storing an old
>> size does not seem very useful.
> 
> This also stores the position and the window state (e.g. whether it was 
> maximized or not).
> 
>> On the other hand, VLC and SMPlayer store their state, so maybe this is
>> what people expect?
> 
> I certainly expect this ;-).
> 
> VLC does both, it stores the state (size, position, maximization, etc.) as 
> well as resizing the window when opening a new video (with an option to 
> disable this).

OK, I applied your patch. Thanks!
http://git.savannah.gnu.org/cgit/bino.git/commit/?id=edb74e45585c84121958e0d3258ced0b928b96ae

I made one small change: the window geometry/state is restored before
opening the initial file(s) given on the command line, so that the
window size is adapted to the files as if they were opened via
File->Open. Is that ok?

Martin