Re: Incorrect interpretation of return code

[Akim Demaille]

| Alexandre Duret-Lutz (address@hidden) writes:
| > 
| > [...]
| > 
| > |        When missing files are copied into place, the return code of the
| > |system command is misinterpreted. Here is the diff:
| > |
| > |6915c6910
| > |<                     elsif (system ('cp', $am_dir . '/' . $file, 
$errfile))
| > |---
| > |>                 elsif (! system ('cp', $am_dir . '/' . $file, $errfile))
| > 
| > Why do you think so?  System returns 0 on success.
|         Yes, system() returns 0 on success. The original version 1.4 has
| 
| > |>                 elsif (! system ('cp', $am_dir . '/' . $file, $errfile))
| 
| which is incorrect.

Sending a context diff would somewhat help.