Re: automake-1.7.1, cygwin: fails gnits2.test

[Alexandre Duret-Lutz]

>>> "chuck" == Charles Wilson <address@hidden> writes:

 chuck> See subject.
 chuck> Here's the output of "env TESTS='gnits2.test' VERBOSE=x make -e check"

Was that really VERBOSE=x?  Normally `x' is a special value that
will cause shell traces to be output, and your output don't have this.

Anyway, thanks for your two reports.  I'm installing the
following patch on HEAD and branch-1-7.

2002-11-30  Alexandre Duret-Lutz  <address@hidden>

        * tests/gnits2.test, tests/gnits3.test: Move the greps inside the
        Makefile, so we can honor $(EXEEXT).  Otherwise these tests
        fail under Cygwin.
        Reported by Charles Wilson.

Index: tests/gnits2.test
===================================================================
RCS file: /cvs/automake/automake/tests/gnits2.test,v
retrieving revision 1.4
diff -u -r1.4 gnits2.test
--- tests/gnits2.test   8 Sep 2002 13:07:55 -0000       1.4
+++ tests/gnits2.test   30 Nov 2002 20:36:44 -0000
@@ -38,6 +38,14 @@
 sub_fubar3_SOURCES = fubar.c
 sub_fine_SOURCES = fine.c
 bin_SCRIPTS = sub/scriptok.sh sub/scriptnok.sh
+
+grep-stderr:
+       grep 'pfubar$(EXEEXT) does not support' stderr
+       grep 'pfubar3$(EXEEXT) does not support' stderr
+       grep 'pscriptnok.sh does not support' stderr
+## Only three failures please.
+       test `grep 'does not support --help' stderr | wc -l` = 3
+       test `grep 'does not support --version' stderr | wc -l` = 3
 END
 
 echo 'int main () { return 0; }' > fubar.c
@@ -93,9 +101,4 @@
 test ! -f ../inst-dir/bin/fine
 $MAKE -k installcheck 2>stderr || : # Never trust the exit status of make -k.
 cat stderr
-grep 'pfubar does not support' stderr
-grep 'pfubar3 does not support' stderr
-grep 'pscriptnok.sh does not support' stderr
-# Only three failures please.
-test `grep 'does not support --help' stderr | wc -l` = 3
-test `grep 'does not support --version' stderr | wc -l` = 3
+$MAKE grep-stderr
Index: tests/gnits3.test
===================================================================
RCS file: /cvs/automake/automake/tests/gnits3.test,v
retrieving revision 1.3
diff -u -r1.3 gnits3.test
--- tests/gnits3.test   8 Sep 2002 13:07:55 -0000       1.3
+++ tests/gnits3.test   30 Nov 2002 20:36:44 -0000
@@ -41,6 +41,13 @@
 nobase_bin_SCRIPTS = nok.sh sub/nok.sh
 
 AM_INSTALLCHECK_STD_OPTIONS_EXEMPT = nok nok.sh
+
+grep-stderr:
+       grep 'sub/pnok$(EXEEXT) does not support' stderr
+       grep 'sub/pnok.sh does not support' stderr
+## Only two failures please.
+       test `grep 'does not support --help' stderr | wc -l` = 2
+       test `grep 'does not support --version' stderr | wc -l` = 2
 END
 
 echo 'int main () { return 0; }' > nok.c
@@ -82,12 +89,7 @@
 $MAKE install
 $MAKE -k installcheck 2>stderr || : # Never trust the exit status of make -k.
 cat stderr
-grep 'sub/pnok does not support' stderr
-grep 'sub/pnok.sh does not support' stderr
-# Only two failures please.
-test `grep 'does not support --help' stderr | wc -l` = 2
-test `grep 'does not support --version' stderr | wc -l` = 2
-
+$MAKE grep-stderr
 
 # Make sure there is no more error when all targets are exempted.
 cd ..

-- 
Alexandre Duret-Lutz