[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: automake 1.8d: missing regexp quoting
|
From: |
Andreas Schwab |
|
Subject: |
Re: automake 1.8d: missing regexp quoting |
|
Date: |
Mon, 19 Jul 2004 16:05:17 +0200 |
|
User-agent: |
Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) |
Alexandre Duret-Lutz <address@hidden> writes:
> On Mon, Jul 19, 2004 at 02:17:32PM +0200, Andreas Schwab wrote:
>> This fixes missing quoting in check_directory.
>>
>> Andreas.
>>
>> 2004-07-19 Andreas Schwab <address@hidden>
>>
>> * automake.in (check_directory): Quote $dir in regexp.
> [...]
>> - if grep (/^$dir$/i, qw/aux lpt1 lpt2 lpt3 com1 com2 com3 com4 con prn/);
>> + if grep (/^\Q$dir\E$/i, qw/aux lpt1 lpt2 lpt3 com1 com2 com3 com4 con
>> prn/);
>
> I'm afraid I have no idea what this fixes. Can you explain?
$dir can contain any kind of special regexp characters, even
syntactically invalid.
Andreas.
--
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."