bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 10 failures in recent automake checkout testsuite under Solaris 9


From: Ralf Wildenhues
Subject: Re: 10 failures in recent automake checkout testsuite under Solaris 9
Date: Fri, 9 Jun 2006 16:32:46 +0200
User-agent: Mutt/1.5.11

* Ralf Menzel wrote on Fri, Jun 09, 2006 at 03:02:17PM CEST:
> Ralf Wildenhues <address@hidden> writes:
> > Which Autoconf version was used for testing?

> --- snip ---
> [anarion:suncc5.8]45> autoconf --version
> autoconf (GNU Autoconf) 2.59e

A nice set of bugs you've found there.  Stepan's patch
http://lists.gnu.org/archive/html/automake-patches/2006-06/msg00001.html
is broken: autoconf has "special magic" to compute $(MKDIR_P) in each
directory -- it may contain a relative path to install-sh.

Then, our distdir change
http://lists.gnu.org/archive/html/automake-patches/2006-05/msg00088.html
isn't right either, because we use $(mkdir_p) from a changed directory.

And while testing I also found a bug in AC_PROG_MAKE_SET: the cache
variable isn't computed right if $MAKE contains a path name... needs
to be fixed in Autoconf.

Below is a patch for the first of the three issues.

Cheers,
Ralf

        * m4/mkdirp.m4 (AM_PROG_MKDIR_P): Set `mkdir_p' to
        `'$(MKDIR_P)'', so that it retains the per-directory value
        computed by config.status.  Report by Ralf Menzel.
        * THANKS: Update.

Index: THANKS
===================================================================
RCS file: /cvs/automake/automake/THANKS,v
retrieving revision 1.284
diff -u -r1.284 THANKS
--- THANKS      6 Jun 2006 20:39:22 -0000       1.284
+++ THANKS      9 Jun 2006 14:24:53 -0000
@@ -232,6 +232,7 @@
 Rafael Laboissiere     address@hidden
 Raja R Harinath                address@hidden
 Ralf Corsepius         address@hidden
+Ralf Menzel            address@hidden
 Ralf Wildenhues                address@hidden
 Ralph Schleicher       address@hidden
 Ramón García Fernández address@hidden
Index: m4/mkdirp.m4
===================================================================
RCS file: /cvs/automake/automake/m4/mkdirp.m4,v
retrieving revision 1.10
diff -u -r1.10 mkdirp.m4
--- m4/mkdirp.m4        7 Jun 2006 05:38:29 -0000       1.10
+++ m4/mkdirp.m4        9 Jun 2006 14:21:43 -0000
@@ -11,5 +11,5 @@
 AC_DEFUN([AM_PROG_MKDIR_P],
 [AC_PREREQ([2.59c])dnl
 AC_REQUIRE([AC_PROG_MKDIR_P])dnl
-AC_SUBST([mkdir_p], [$MKDIR_P])dnl
+AC_SUBST([mkdir_p], ['$(MKDIR_P)'])dnl
 ])




reply via email to

[Prev in Thread] Current Thread [Next in Thread]