[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Should use backslashes in depend2.am
From: |
Jan Engelhardt |
Subject: |
Re: [PATCH] Should use backslashes in depend2.am |
Date: |
Sun, 21 Oct 2007 21:28:19 +0200 (CEST) |
On Oct 21 2007 21:22, Ralf Wildenhues wrote:
>>
>> My "don't be so verbose" patch (now posix compliant as it seems to
>> have turned out) - where the full command needs to be (read: should
>> be, preferably, but not striclty necessary) on one line, as @echo is
>> used.
>
>Hmm, can't you just push that onto your patch? The way the code is
>written now it saves one shell invocation per compilation, which is
>a nice speedup for gcc users. GNU make implements this optimization:
>in case the rule command does not contain shell active characters,
>it execs the compiler right away instead of `sh -c ...'.
>
>> Since ?SUBDIROBJ? uses &&\ I thought it would not hurt too much to also
>> use it in the ?!SUBDIROBJ? case.
>
>Well, in the ?SUBDIROBJ? case there is a shell command substitution
>`cmd`, so in that case the shell will be invoked anyway.
Ah, ok.
Well, just thought, being in sync with upstream as close as possible, but well,
reasonable argument.