[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: failure in "colorful tests"
From: |
Bob Proulx |
Subject: |
Re: failure in "colorful tests" |
Date: |
Mon, 12 Nov 2007 16:41:01 -0700 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Ralf Wildenhues wrote:
> +case $TERM in
> +dumb) exit 77;;
> +esac
> ...
> Thanks! Do we need to guard against other TERM settings, too?
Hmm... I was thinking more along the lines of this patch instead. I
don't think the test should be skipped. I think it should be made
independent of the invoking user's TERM. Because the test is
self-contained it does not depend upon the user's TERM setting.
In fact I think it is required because ansi escape sequences were
coded into the script. That means if this is run on a non-ansi
terminal it would fail.
[This dependence upon TERM but the assumption of ansi escape sequences
in the test may account for tput "failures" on non-ansi terminals that
you reported during development. (shrug) Not sure but it seems
plausible to me.]
Bob
diff --git a/tests/color.test b/tests/color.test
index d30d1e0..ed88c10 100755
--- a/tests/color.test
+++ b/tests/color.test
@@ -20,6 +20,9 @@
# Test Automake TESTS color output.
+TERM=ansi
+export TERM
+
. ./defs || exit 1
set -e