Re: automake-1.10.1 unit test failures

[Ralf Wildenhues]

Hello Alexander,

Thanks for your feedback.  Please don't top-post though, and let's keep
the mailing list in Cc:.

* Alexander Martens wrote on Wed, Oct 08, 2008 at 09:03:58AM CEST:
>
> I've solved that already. There were two problems involved:
>
> 1) I was running as root (known issue already reported for inst2sh)

Yep, that has been fixed since.

> 2) Didn't have tex2dvi installed. This one can be understood under  
> RHEL5.2 because of a clumsy description in the rpm packages:
> "texinfo-xxxx.rpm" does not contain texi2dvi (I already had this one),  
> but "texinfo-tex-xxxxx.rpm" does. Descriptions are:
> "Tools needed to create Texinfo format documentation files" for  
> "texinfo-xxxx.rpm"
> "Tools for fromating (sic) Texinfo documentation files using TeX" for  
> "texinfo-text-xxxx.rpm"

Wow, interesting.  You might want to consider filing a bug report with
RedHat.  They may have done this separation accidentally, or have that
missing package dependency unintentionally, in which case they would
probably be interested in hearing about it.  Or they may do this by
intention, to save space for example for those that only need info,
I can't tell.

Anyway, I'm installing the patch below (master and branch-1-10) and
putting you in THANKS.

> I feel like a newbie today.

There is absolutely no reason for that.  The Automake test suite should
be tolerant to running as root, and to missing packages.

Cheers,
Ralf

    Require texi2dvi in tests, makeinfo may not be enough.
    
    * tests/txinfo16.test: RHEL 5.2 has makeinfo and texi2dvi in
    separate packages, so also list the latter as required, as the
    test generates DVI and/or PDF output (through distcheck).
    * tests/txinfo18.test: Likewise.
    * tests/txinfo21.test: Likewise.
    * tests/txinfo22.test: Likewise.
    * tests/txinfo3.test: Likewise.
    * tests/version7.test: Likewise.
    * THANKS: Update.
    Report by Alexander Martens.
    
    Signed-off-by: Ralf Wildenhues <address@hidden>

diff --git a/tests/txinfo16.test b/tests/txinfo16.test
index ec5d4cb..a82cb27 100755
--- a/tests/txinfo16.test
+++ b/tests/txinfo16.test
@@ -1,5 +1,5 @@
 #! /bin/sh
-# Copyright (C) 2002, 2003  Free Software Foundation, Inc.
+# Copyright (C) 2002, 2003, 2008  Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -16,7 +16,7 @@
 
 # Check that info files are not built in $(srcdir).
 
-required='makeinfo tex'
+required='makeinfo tex texi2dvi'
 . ./defs || Exit 1
 
 set -e
diff --git a/tests/txinfo18.test b/tests/txinfo18.test
index 1ee6f3e..f847b63 100755
--- a/tests/txinfo18.test
+++ b/tests/txinfo18.test
@@ -1,5 +1,5 @@
 #! /bin/sh
-# Copyright (C) 2002  Free Software Foundation, Inc.
+# Copyright (C) 2002, 2008  Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -18,7 +18,7 @@
 # Only *new* indexes need to be declared at the top-level.
 # PR/375.
 
-required='makeinfo tex'
+required='makeinfo tex texi2dvi'
 . ./defs || Exit 1
 
 set -e
diff --git a/tests/txinfo21.test b/tests/txinfo21.test
index c4c47eb..c94f798 100755
--- a/tests/txinfo21.test
+++ b/tests/txinfo21.test
@@ -1,5 +1,5 @@
 #! /bin/sh
-# Copyright (C) 2003, 2004, 2006  Free Software Foundation, Inc.
+# Copyright (C) 2003, 2004, 2006, 2008  Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -17,7 +17,7 @@
 # Test support for building HTML documentation, and the many
 # install-DOC flavors.
 
-required='makeinfo-html tex'
+required='makeinfo-html tex texi2dvi'
 . ./defs || Exit 1
 
 set -e
diff --git a/tests/txinfo22.test b/tests/txinfo22.test
index 5533f98..f90a02b 100755
--- a/tests/txinfo22.test
+++ b/tests/txinfo22.test
@@ -20,7 +20,7 @@
 # but preserve them in the output.
 # Also make sure TEXINFO_TEX is not distributed.
 
-required='makeinfo tex'
+required='makeinfo tex texi2dvi'
 . ./defs || Exit 1
 
 set -e
diff --git a/tests/txinfo3.test b/tests/txinfo3.test
index 6dd553f..367547e 100755
--- a/tests/txinfo3.test
+++ b/tests/txinfo3.test
@@ -1,5 +1,6 @@
 #! /bin/sh
-# Copyright (C) 1997, 2001, 2002, 2003  Free Software Foundation, Inc.
+# Copyright (C) 1997, 2001, 2002, 2003, 2008  Free Software Foundation,
+# Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -16,7 +17,7 @@
 
 # Test to make sure .info-less @setfilename works.
 
-required='makeinfo tex'
+required='makeinfo tex texi2dvi'
 . ./defs || Exit 1
 
 set -e
diff --git a/tests/version7.test b/tests/version7.test
index dc28465..91f7a99 100755
--- a/tests/version7.test
+++ b/tests/version7.test
@@ -1,5 +1,5 @@
 #! /bin/sh
-# Copyright (C) 2002  Free Software Foundation, Inc.
+# Copyright (C) 2002, 2008  Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -19,7 +19,7 @@
 # is to make sure Makefile.ins get rebuilt when a m4_included file
 # changes -- we don't support this feature on non-GNU Makes).
 
-required='makeinfo tex GNUmake'
+required='makeinfo tex texi2dvi GNUmake'
 . ./defs || Exit 1
 
 set -e