Re: Incorrect use of USE_XATTR in coreutils-8.4

[Pádraig Brady]

On 22/01/10 13:17, Jim Meyering wrote:
> [Cc'd autoconf for a suggestion below]
>
> Pádraig Brady wrote:
> > +       @grep -Ei '^#define.*(yes|no|true|false)$$' lib/config.h&&      \
> > +         { echo 'Please use 0 or 1 for macro values' 1>&2; exit 1; }
> > +
>
> I like it.
>
> However, it'd sure be nice to use something more generic than
> lib/config.h.  IMHO, autoconf should make configure AC_SUBST its
> currently-internal-only CONFIG_HEADERS variable.  While we wait,
> I suppose we can kludge it by extracting the first file name
> from the use of AC_CONFIG_HEADER(S)? in configure.ac.

I think $(CONFIG_HEADER) is auto exported but that doesn't seem
to be documented. How about this patch to automake?

From 73f95546e35bd84f00c97f667d05796a131c5fc2 Mon Sep 17 00:00:00 2001
From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
Date: Fri, 29 Jan 2010 08:05:38 +0000
Subject: [PATCH] CONFIG_HEADER: document the availability of this variable.

* doc/automake.texi (Other things Automake recognizes, Optional):
Mention that $(CONFIG_HEADER) is available to Makefiles, which
seems to be the case since commit 6a929893, 1996-01-22,
"Handle AC_CONFIG_HEADER."
---
 ChangeLog         |    6 ++++++
 doc/automake.texi |    5 +++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 14756d1..08b5dc7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2010-01-29  Pádraig Brady <address@hidden>
+
+       CONFIG_HEADER: document the availability of this variable.
+       * doc/automake.texi (Other things Automake recognizes, Optional):
+       Mention that $(CONFIG_HEADER) is available to Makefiles.
+
 2009-05-24  Jack Kelly  <address@hidden>  (tiny change)
            Ralf Wildenhues  <address@hidden>

diff --git a/doc/automake.texi b/doc/automake.texi
index 6c6765f..0f81d35 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -2858,10 +2858,15 @@ Automake will require the sources file declared with
 macro.

 @item AC_CONFIG_HEADERS
address@hidden CONFIG_HEADER
 Automake will generate rules to rebuild these headers.  Older versions
 of Automake required the use of @code{AM_CONFIG_HEADER}
 (@pxref{Macros}); this is no longer the case.

+The relative location of the first header defined in @code{AC_CONFIG_HEADERS}
+will be made available to each @file{Makefile.in} through the
address@hidden(CONFIG_HEADER)} variable.
+
 As for @code{AC_CONFIG_FILES} (@pxref{Requirements}), parts of the
 specification using shell variables will be ignored as far as
 cleaning, distributing, and rebuilding is concerned.
--
1.6.2.5