Re: Truncated comment in Makefile.am

[Ralf Wildenhues]

Hi Stefano,

* Stefano Lattarini wrote on Fri, Apr 30, 2010 at 05:25:17PM CEST:
> The commit f7587e184a52785913eda87fbb6ff6f0bc2aeb29 ("Ensure we don't 
> print 'warning:' or 'error:' twice.") introduced a truncated comment 
> in Makefile.am, at target `sc_tests_logs_duplicate_prefixes'" .  I'm not 
> sure how that comment should be completed, so I just signal it here 
> instead of attempting a patch.

Nicely spotted; thanks!  I think that was just because, when writing the
patch, I first had the requirement for the testsuite to have run before
integrated into this target; when factoring it out, I adjusted the
comment above sc_ensure_testsuite_has_run but didn't fully fix the other
one.

Cheers,
Ralf

    Fix truncated comment in Makefile.am.
    
    * Makefile.am (sc_tests_logs_duplicate_prefixes): Fix unfinished
    sentence in comment.
    Report by Stefano Lattarini.

diff --git a/Makefile.am b/Makefile.am
index 829418b..a13558b 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -470,7 +470,7 @@ sc_ensure_testsuite_has_run:
 .PHONY: sc_ensure_testsuite_has_run
 
 ## Ensure our warning and error messages do not contain duplicate 'warning:' 
prefixes.
-## This test actually depends on the testsuite having been run before; but it 
would be
+## This test actually depends on the testsuite having been run before.
 sc_tests_logs_duplicate_prefixes: sc_ensure_testsuite_has_run
        @if grep -E '(warning|error):.*(warning|error):' tests/*.log; then \
          echo 'Duplicate warning/error message prefixes seen in above tests.' 
>&2; \