Re: [PATCH] Work around a nasty bug of Solaris make

[Eric Blake]

On 08/05/2010 04:44 PM, Stefano Lattarini wrote:
>> Thanks for the report.  A segfault in make is always a bug in the
>> make implementation.  If we can easily find out what makes it
>> fail, and can easily and reliably work around it, then let's maybe
>> consider it, but otherwise let's not bother.
> The attached patch does the fix.  It's basically just a one-liner
> with a two-line comment.  I think we should apply it, since Automake
> already contains tons of uglier and much more cumbersome workarounds.

Won't work.

+             done | tr '\012\015' '  ' | sed 's/ *$$//'`;              

sed requires text input (aka a trailing newline), but the tr produced
non-text output by converting to spaces.  You'd need something like:

done | { tr '\012\015' '  '; echo; } | sed 's/ *$$//'

to remain portable to all sed.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature