bug#10026: branch-11.1 testsuite on Solaris 10 [3] (XPG4 sh, Sun Studio compilers, autoconf 2.62) [almost OK]

[Stefano Lattarini]

SETUP:

  Solaris 10, "rich /usr/local" (e.g., contains `expr' from GNU coreutils
  6.9 and gawk 3.1.5), VPATH build, perl 5.10.0, autoconf 2.62, testsuite
  run with GNU make 3.82, test scripts run by /usr/xpg4/bin/sh,
  $CONFIG_SHELL set to /usr/xpg4/bin/sh as well, compilers are from Sun
  Studio 5.9 (2010/08/11) and libtool 2.4.2.


RESULTS:

  Four spurious failures, and a failure I haven't analyzed yet.

  Three failures are due to minor testsuite weaknesses, as some tests that
  should be skipped (ar-lib.test, compile3.test and compile6.test) are
  erroneously run, and they (unsurprisingly) fail.  This issue should be
  already solved in the `testsuite-work' branch, and IMHO is not worth
  worrying about.

  Another spurious failure (uninstall-fail.test) has been fixed by the
  attached patch (pushed to maint).

  The test texinfo21.test fails, and I don't know why :-(  Will have to
  take a better look.

config.log
Description: Text Data

test-suite.log
Description: Text Data

From eae36caf547319469b378d12b90a9f82338fa322 Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Sat, 12 Nov 2011 18:41:53 +0100
Subject: [PATCH] tests: fix spurious error in 'uninstall-fail.test' on Solaris

* tests/uninstall-fail.test: Solaris 10 /usr/xpg4/bin/sh can add
a line number before the `:' in the error messages issued by shell
builtins.  Account for that in our grepping of make output.
---
 ChangeLog                 |    7 +++++++
 tests/uninstall-fail.test |   19 +++++++++++++++++--
 2 files changed, 24 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 79bcb89..8934813 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
 2011-11-12  Stefano Lattarini  <address@hidden>
 
+       tests: fix spurious error in 'uninstall-fail.test' on Solaris
+       * tests/uninstall-fail.test: Solaris 10 /usr/xpg4/bin/sh can add
+       a line number before the `:' in the error messages issued by shell
+       builtins.  Account for that in our grepping of make output.
+
+2011-11-12  Stefano Lattarini  <address@hidden>
+
        tests: fix typo in 'uninstall-fail.test'
        * tests/uninstall-fail.test: Always use `$rm_f_is_silent_on_error'
        instead of the bogus `$rm_f_is_silent_on_failure'.
diff --git a/tests/uninstall-fail.test b/tests/uninstall-fail.test
index 2fc3197..529d8f3 100755
--- a/tests/uninstall-fail.test
+++ b/tests/uninstall-fail.test
@@ -76,8 +76,23 @@ chmod a-rwx $inst/share
 
 $MAKE uninstall >output 2>&1 && { cat output; Exit 1; }
 cat output
+#
 # Some shells, like Solaris 10 /bin/sh and /bin/ksh, do not report
-# the name of the `cd' builtin upon a chdir error.
-$EGREP "(cd|sh): .*$inst/share" output
+# the name of the `cd' builtin upon a chdir error:
+#
+#   $ /bin/sh -c 'cd /none'
+#   /bin/sh: /none: does not exist
+#
+# In addition, some shells, like Solaris 10 /usr/xpg4/bin/sh, also print
+# a line number in the error message *if the command contains newlines*:
+#
+#   $ /usr/xpg4/bin/sh -c 'cd unreadable'
+#   /usr/xpg4/bin/sh: unreadable: permission denied
+#   $ /usr/xpg4/bin/sh -c '\
+#   > \
+#   > cd unreadable'
+#   /usr/xpg4/bin/sh[3]: unreadable: permission denied
+#
+$EGREP "(cd|sh)(\[[0-9]*[0-9]\])?: .*$inst/share" output
 
 :
-- 
1.7.2.3