[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10441: The testsuite assumes that ln -s really creates a symlink
From: |
Peter Rosin |
Subject: |
bug#10441: The testsuite assumes that ln -s really creates a symlink |
Date: |
Sun, 08 Jan 2012 16:49:13 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
Stefano Lattarini skrev 2012-01-08 13:56:
> On 01/05/2012 11:13 PM, Peter Rosin wrote:
>> Hi!
>>
> Hi Peter, thanks for the report.
>
>> "ln -s" on MSYS does not create a symlink, instead it makes a
>> regular copy. Lots of test cases (on master) FAIL due to this.
>>
>> "test -h foo" will simply not return success on MSYS, ever.
>>
>> Affected tests (that I have noticed):
>> add-missing.tap (lots of failing test cases)
>> copy.test
>>
> The attached patch should take care of the problem. Tested using
> this script in PATH as the `ln' program:
>
> #!/bin/bash
> declare -a args=()
> for i in "$@"; do
> test x"$i" = x"-s" && continue
> args=("address@hidden" "$i")
> done
> exec /bin/ln "address@hidden"
>
> I will push after your ACK or in 48 hours, whichever comes first.
add-missing.tap: 351 PASS, 50 skip
copy.test: PASS
Thanks!
Cheers,
Peter