bug-automake
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#13514: unintentional regression with AC_CONFIG_MACRO_DIR in 1.13.1


From: Pavel Raiskup
Subject: bug#13514: unintentional regression with AC_CONFIG_MACRO_DIR in 1.13.1
Date: Fri, 08 Feb 2013 13:56:23 +0100

Hi Stefano,

> >> [ ... ]
> > 
> > Ping.  Are you considering my opinions OK?
> >
> Basically yes; and a patch would obviously be welcome, if you want
> to speed up the fixing of this bug ;-)

First proposal attached :) (0001-*).

> > Quickly again (let's say that AC_CONFIG_MACRO_DIR([m4]) is specified):
> >   a) Warn because 'aclocal -I m4'
> >
> It should be just 'aclocal' here.  The point of the new code is that,
> if you specify a directory as argument to AC_CONFIG_MACRO_DIR, you
> don't need to repeat it again on the aclocal command line nor in
> ACLOCAL_AMFLAGS anymore.

This may cause problems when user wants to use gettext && specify target
directory on a different place than 'm4'.  For these I'm attaching the
0003-* patch.

> >      wants to search 'm4' dir which does not
> >      exist.  Ignoring this completely is imo idea;
> >
> s/idea/bad idea/ here, I guess.  Right?  IF yes, I mostly agree.

Yes - typo, sorry.

> To summarize: for what concerns automake, I think degrading the fatal
> error in aclocal to a warning is the best and safest approach for now.
> Improvements or re-tightening can be done later, if needed.

Done.

The purpose of patch 0002-* should be obvious from its description.
Patches are generated against 1.13.2 branch.

Pavel


Attachment: 0001-maint-Warn-only-if-primary-Idir-directory-does-not-e.patch
Description: Text Data

Attachment: 0002-maint-Fix-for-more-than-once-specified-directories.patch
Description: Text Data

Attachment: 0003-docs-Mention-consequences-with-AC_CONFIG_MACRO_DIRS.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]