bug#16841: Bug#738716: automake: Generates syntax error in configure script

[Stefano Lattarini]

tags 16841 + patch
close 16841
thanks

On 02/22/2014 08:40 AM, Eric Dorland wrote:
> * Hilko Bengen (address@hidden) wrote:
> > Source: automake-1.14
> > Version: 1:1.14.1-2
> > Severity: critical
> > Tags: patch
> >
> > While trying to build a new version of nbdkit, I fonud that a freshly
> > generated configure script contains a syntax error:
> >
> > ,----
> > | $ curl -O http://libguestfs.org/download/nbdkit/nbdkit-1.1.4.tar.gz
> > | [...]
> > | $ tar xzf nbdkit-1.1.4.tar.gz
> > | $ cd nbdkit-1.1.4/
> > | $ autoreconf
> > | $ ./configure
> > | [...]
> > | checking for style of include used by make... GNU
> > | checking whether make supports nested variables... yes
> > | checking dependency style of gcc... gcc3
> > | ./configure: line 4820: syntax error near unexpected token `case'
> > | ./configure: line 4820: `fi case `pwd` in'
> > `----
> >
> > To me, this looks like a missing newline at the end of AM_INIT_AUTOMAKE
> > in /usr/share/aclocal-1.14/init.m4. At least the attached patch fixes
> > the problem for me.
>
> It looks like the problem is the dnl on your AM_INIT_AUTOMAKE line:
>
> AM_INIT_AUTOMAKE(foreign) dnl NB: Do not [quote] this parameter.
>
> That's suppressing the natural new line that would be there. But I
> think the patch is legitimate so forwarding it along.
>
> > --- /usr/share/aclocal-1.14/init.m4.orig        2014-02-12 09:45:22.883382346 
> > +0100
> > +++ /usr/share/aclocal-1.14/init.m4     2014-02-12 09:45:40.758921507 +0100
> > @@ -164,7 +164,8 @@
> >   END
> >       AC_MSG_ERROR([Your 'rm' program is bad, sorry.])
> >     fi
> > -fi])
> > +fi
> > +])
> >
> >   dnl Hook into '_AC_COMPILER_EXEEXT' early to learn its expansion.  Do not
> >   dnl add the conditional right here, as _AC_COMPILER_EXEEXT may be further
Agreed, we shouldn't have broken backward-compatibility for no good reason
(and IIRC the removal of the trailing newline wasn't deliberated).  Fixed
with the attached patch.

Thanks,
  Stefano

0001-AM_INIT_AUTOMAKE-make-sure-has-a-trailing-newline-af.patch
Description: Text Data