bug#23839: automake git repository not cloneable with fsckobjects=true

[Kyle J. McKay]

The automake git repository on git.savannah.gnu.org is unclonable
when transfer.fsckObjects=true is set because it contains invalid
annotated (but unsigned) tag objects.

These tag objects should be fixed.

Since they are tag objects, they will not break anyone's forks as
the forks will be off the commit they refer to.  Since they are
unsigned, there are no signatures to invalidate by fixing them.

There's really no downside to fixing these broken tag objects.

To this end, I have included the contents of an "automake-fix-tags.txt"
file (that can be fed to git fast-import to correct the problem
tags) at the end of this email.  The missing email and timestamp
information to fix the broken tag objects was taken from the commit
object that each of the problem tags refers to.

Here's a sample shell session demonstrating the issue and the fix:

$ git -c transfer.fsckobjects=true clone --mirror 
http://git.savannah.gnu.org/r/automake.git
Cloning into bare repository 'automake.git'...
remote: Counting objects: 93573, done.
remote: Compressing objects: 100% (12918/12918), done.
error: object 9cad3e05f3ef91e317b69ac514edd8bc63bb1275: missingEmail: invalid 
author/committer line - missing email
fatal: Error in object
fatal: index-pack failed

$ git -c transfer.fsckobjects=false clone --mirror 
http://git.savannah.gnu.org/r/automake.git
Cloning into bare repository 'automake.git'...
remote: Counting objects: 93573, done.
remote: Compressing objects: 100% (12918/12918), done.
remote: Total 93573 (delta 80496), reused 93573 (delta 80496)
Receiving objects: 100% (93573/93573), 20.25 MiB
Resolving deltas: 100% (80496/80496), done.
Checking connectivity... done.

$ cd automake.git

$ git fsck --no-progress --no-dangling && echo yea || echo boo
error in tag 9cad3e05f3ef91e317b69ac514edd8bc63bb1275: missingEmail: invalid 
author/committer line - missing email
[...100+ more errors of the same type elided...]
error in tag ba2ab16b22ad71800a40242c98b3f3a88367e16a: missingEmail: invalid 
author/committer line - missing email
boo

$ git for-each-ref '--format=%(refname) %(object) %(*creatordate)' refs/tags |
openssl dgst -md5
(stdin)= f0b6029239f454595c982b653a5b20a4

$ git fast-import < ../automake-fix-tags.txt
git-fast-import statistics:
---------------------------------------------------------------------
Alloc'd objects:       5000
Total objects:          112 (         0 duplicates                  )
      blobs  :            0 (         0 duplicates          0 deltas of         
 0 attempts)
      trees  :            0 (         0 duplicates          0 deltas of         
 0 attempts)
      commits:            0 (         0 duplicates          0 deltas of         
 0 attempts)
      tags   :          112 (         0 duplicates          0 deltas of         
 0 attempts)
Total branches:           0 (         0 loads     )
      marks:           1024 (         0 unique    )
      atoms:              0
Memory total:          2282 KiB
       pools:          2048 KiB
     objects:           234 KiB
---------------------------------------------------------------------
pack_report: getpagesize()            =       4096
pack_report: core.packedGitWindowSize = 1073741824
pack_report: core.packedGitLimit      = 8589934592
pack_report: pack_used_ctr            =        336
pack_report: pack_mmap_calls          =          2
pack_report: pack_open_windows        =          2 /          2
pack_report: pack_mapped              =   21249857 /   21249857
---------------------------------------------------------------------

$ git for-each-ref '--format=%(refname) %(object) %(*creatordate)' refs/tags |
openssl dgst -md5
(stdin)= f0b6029239f454595c982b653a5b20a4

$ git gc --quiet --prune=now

$ git fsck --no-progress --no-dangling && echo yea || echo boo
yea

Cheers,

Kyle

P.S. It looks to me like the version of Git the git.savannah.gnu.org
server is running probably ought to be upgraded soonish.

---- BEGIN automake-fix-tags.txt FILE ----
tag Release-0-25
from b256f4307793c78a477c623d9c6209c039b4e786
tagger Tom Tromey <address@hidden> 818636335 +0000
data 0

tag Release-0-26
from ba67303b4416e14b1b0dea29223918fe6ad17eb5
tagger Tom Tromey <address@hidden> 820654716 +0000
data 0

tag Release-0-27
from 64e466de100b61835e7b54f6bee9bde52ad17cc8
tagger Tom Tromey <address@hidden> 820697188 +0000
data 0

tag Release-0-28
from f3a30c39d1773602296a62c8fc1680a272b1d40b
tagger Tom Tromey <address@hidden> 821597370 +0000
data 0

tag Release-0-29
from 7fee9fa5b426ea08a450c4570593d4f464376548
tagger Tom Tromey <address@hidden> 823747643 +0000
data 0

tag Release-0-30
from 90b242c75d724d7b5258331e59fad2cb1bec0285
tagger Tom Tromey <address@hidden> 825447558 +0000
data 0

tag Release-0-31
from 6c31674dd6a374599ace24380fb4fcbe9d8e6bb7
tagger Tom Tromey <address@hidden> 826767155 +0000
data 0

tag Release-0-32
from 395abbdae6a5ee672875f7d446aa99f9a32f1f7c
tagger Tom Tromey <address@hidden> 830633171 +0000
data 0

tag Release-0-33
from d0ef18688f8f3dacdfd0f54fa16a56ab50dfcf32
tagger Tom Tromey <address@hidden> 832632728 +0000
data 0

tag Release-1-0
from fdbf01e918bc62e7b15fa7d82808652c9533a445
tagger Tom Tromey <address@hidden> 833333436 +0000
data 0

tag Release-1-10
from 6fe073e51daf543adc205118b13e10c8b7a88280
tagger Alexandre Duret-Lutz <address@hidden> 1160939212 +0000
data 0

tag Release-1-1a
from 9628f3ab9a1c869f64c6061232a8cd68356de2e1
tagger Tom Tromey <address@hidden> 839042002 +0000
data 0

tag Release-1-1b
from defb3f78fd7de2626b58417e95dad4570828b1db
tagger Tom Tromey <address@hidden> 839288443 +0000
data 0

tag Release-1-1c
from a004f05f95dd9f039db0b3c7e3ff91166e3a519a
tagger Tom Tromey <address@hidden> 839791688 +0000
data 0

tag Release-1-1d
from 86234b97fd3696790ea7b6543e4b902d4960ce78
tagger Tom Tromey <address@hidden> 842464501 +0000
data 0

tag Release-1-1e
from 45a3c61b63c2d02a529c18afb89baed356ebb3c7
tagger Tom Tromey <address@hidden> 842466758 +0000
data 0

tag Release-1-1f
from 3480a30b361a2b44e94ba26342dae751f64abaa3
tagger Tom Tromey <address@hidden> 844588898 +0000
data 0

tag Release-1-1g
from c6d1731c5e7323041477de4e34d7d367d0395171
tagger Tom Tromey <address@hidden> 847496196 +0000
data 0

tag Release-1-1h
from 068a2710856ec5f90f58f2aaa6506422c975d221
tagger Tom Tromey <address@hidden> 849478374 +0000
data 0

tag Release-1-1i
from 37ebfe308d48572f3df565f5a587cf9409ab1e8a
tagger Tom Tromey <address@hidden> 849561983 +0000
data 0

tag Release-1-1k
from d611836d201173e98a549b0331750e39515dbe55
tagger Tom Tromey <address@hidden> 849849374 +0000
data 0

tag Release-1-1l
from fa7528a0e91a586f63b38a99fdc969609ebd62d6
tagger Tom Tromey <address@hidden> 850177418 +0000
data 0

tag Release-1-1m
from 888737840dff2a9207af1edf347c5ce29cfe4a31
tagger Tom Tromey <address@hidden> 858815930 +0000
data 0

tag Release-1-1o
from fb7a6a60adcce5ce27b523b8c90f4fa36d8359b7
tagger Tom Tromey <address@hidden> 862211901 +0000
data 0

tag Release-1-1p
from 76f845e0b206c7ae242b2aae92e41cec9d88fb10
tagger Tom Tromey <address@hidden> 863310741 +0000
data 0

tag Release-1-2
from 2deb04fc56304ba56c04e8ef369e07793b7a0778
tagger Tom Tromey <address@hidden> 867032200 +0000
data 0

tag Release-1-2b
from 783bc580cdda1cc4aad6a372d45a52974800e842
tagger Tom Tromey <address@hidden> 875167027 +0000
data 0

tag Release-1-2c
from 92e7f9f85bac32e6e00ff7f9d1dca35a901cdea7
tagger Tom Tromey <address@hidden> 875561183 +0000
data 0

tag Release-1-2d
from 1ad640406bdbdc6ac40ce4370c4a4fe034b31991
tagger Tom Tromey <address@hidden> 880580889 +0000
data 0

tag Release-1-2e
from 3843d6429468d665adbbe3b846e715324e12a858
tagger Tom Tromey <address@hidden> 887355506 +0000
data 0

tag Release-1-2g
from 4816911e743ba64c5d4a11e66ed7588e3fb9ef35
tagger Tom Tromey <address@hidden> 890293891 +0000
data 0

tag Release-1-2h
from 8b9a5afd8eb8b7564f416141aa599a4c34e18ab8
tagger Tom Tromey <address@hidden> 890677910 +0000
data 0

tag Release-1-3
from 41f18c10f80762323024c9c514a08bc9071464d7
tagger Tom Tromey <address@hidden> 891838102 +0000
data 0

tag Release-1-3b
from d75bed2b71d30743d4a0d430ab9f74212e217324
tagger Tom Tromey <address@hidden> 902953122 +0000
data 0

tag Release-1-3d
from 5b2b39cc7a4b4261e4c15b57c6ab78df3e8744c2
tagger Tom Tromey <address@hidden> 912602901 +0000
data 0

tag Release-1-4
from f61264d080ab77cf185608396ae0961fc7ebe986
tagger Tom Tromey <address@hidden> 916354040 +0000
data 0

tag Release-1-4-p1
from cbf349347eee712cff12e947bc214c551788c860
tagger Gary V. Vaughan <address@hidden> 989368852 +0000
data 0

tag Release-1-4-p2
from 8014fb6a9f207ca4a41e21f1bcdf7f551a1e7e70
tagger Gary V. Vaughan <address@hidden> 990736542 +0000
data 0

tag Release-1-4-p3
from 9fa65574d5ac46e1fd9276a15e865fd4767671da
tagger Gary V. Vaughan <address@hidden> 991944231 +0000
data 0

tag Release-1-4-p4
from 08ccb11d659b496a4d7bcd03af8d23192aee0e82
tagger Gary V. Vaughan <address@hidden> 992169170 +0000
data 0

tag Release-1-4-p5
from 4b22a8689d6887dfcb2c4e93b1a8e224b00c71fb
tagger Gary V. Vaughan <address@hidden> 995217472 +0000
data 0

tag Release-1-4-p6
from f3efc5f39a0b77ed9a099bcebb45b99e3d4e46f7
tagger Tom Tromey <address@hidden> 1027803816 +0000
data 0

tag Release-1-4b
from 409b58a88793dfa4f068749a41d0fa3add7d1aed
tagger Tom Tromey <address@hidden> 977607030 +0000
data 0

tag Release-1-4d
from e53585cb65541c1aa0d7daec2bc21cca470730d4
tagger Tom Tromey <address@hidden> 982047178 +0000
data 0

tag Release-1-4f
from 35a256030bf7be53e3cc69c1caa12f9377cb9231
tagger Tom Tromey <address@hidden> 990379065 +0000
data 0

tag Release-1-4h
from da09285c393c4078d99a67b5813a39cd61f03395
tagger Tom Tromey <address@hidden> 994217116 +0000
data 0

tag Release-1-4j
from 60903702f6440e19c3ca520cd36ea0c278a730c7
tagger Tom Tromey <address@hidden> 996558325 +0000
data 0

tag Release-1-4l
from 599f4610cc9e3553a9a3c5a1c83051df354f26fa
tagger Tom Tromey <address@hidden> 997566092 +0000
data 0

tag Release-1-5
from 06b28c26878b9533c584e46c6f9572edee18f2d4
tagger Tom Tromey <address@hidden> 998543850 +0000
data 0

tag Release-1-5b
from 80b24bbdc1edcff9192b5e596ed6e1021c77f5c7
tagger Alexandre Duret-Lutz <address@hidden> 1008347137 +0000
data 0

tag Release-1-5d
from 3e7cf22c51d652825e95574e05d8051dd90bcf11
tagger Tom Tromey <address@hidden> 1012180169 +0000
data 0

tag Release-1-6
from c75d6ce9a3dbd014c396a1c74237e7b3055682e0
tagger Tom Tromey <address@hidden> 1015389932 +0000
data 0

tag Release-1-6-1
from 55222e97f76dfd27f024c753b32e543f4e5847e6
tagger Alexandre Duret-Lutz <address@hidden> 1018507293 +0000
data 0

tag Release-1-6-1b
from fb1068df79a9d2227ca4bf26627871eda177756e
tagger Alexandre Duret-Lutz <address@hidden> 1023736500 +0000
data 0

tag Release-1-6-2
from b61505ffe76d5e832ecae8f20dfd991570d26a7d
tagger Alexandre Duret-Lutz <address@hidden> 1024039466 +0000
data 0

tag Release-1-6-3
from 0a3e51265335d92f216db36654bb58b05fdb7097
tagger Alexandre Duret-Lutz <address@hidden> 1027877312 +0000
data 0

tag Release-1-6b
from c7d71ee476e674e6dbb566efa3bdb0005063f7c8
tagger Alexandre Duret-Lutz <address@hidden> 1027882066 +0000
data 0

tag Release-1-6d
from a0a144cd8b5da652ca9b663676475e4b8b5244d1
tagger Alexandre Duret-Lutz <address@hidden> 1032383127 +0000
data 0

tag Release-1-6f
from 903ee52523e96762f16d3de6771be12fe076dfef
tagger Alexandre Duret-Lutz <address@hidden> 1032520804 +0000
data 0

tag Release-1-7
from c2d90d2ee1f1446cf6efe4d0ecdbd374b6da4041
tagger Alexandre Duret-Lutz <address@hidden> 1032985033 +0000
data 0

tag Release-1-7-1
from 43f20ce1a2d70aeea622be66db64bd849c359bb8
tagger Alexandre Duret-Lutz <address@hidden> 1034799398 +0000
data 0

tag Release-1-7-1b
from 0201adcade120e398194e3c387e341bcea277d48
tagger Alexandre Duret-Lutz <address@hidden> 1038770723 +0000
data 0

tag Release-1-7-2
from ae9cfcf8cca736ccd5e0910b119b40a2dced6a43
tagger Alexandre Duret-Lutz <address@hidden> 1039125832 +0000
data 0

tag Release-1-7-2b
from 3354069d5cac826f0020075d4123f8c24cf91eb9
tagger Alexandre Duret-Lutz <address@hidden> 1045067201 +0000
data 0

tag Release-1-7-3
from 2f11399a770402eed55b0656681c4ea7bbbc800d
tagger Alexandre Duret-Lutz <address@hidden> 1045763116 +0000
data 0

tag Release-1-7-3b
from b0bc85201383232309199b3102323c19e5bd73a2
tagger Alexandre Duret-Lutz <address@hidden> 1050695971 +0000
data 0

tag Release-1-7-4
from 3da871ef3e5e13d678beb3f3d669faf9e0441b51
tagger Alexandre Duret-Lutz <address@hidden> 1051132386 +0000
data 0

tag Release-1-7-5
from 882d3bf3d702f0363f04439ae8ed73be4df69ad4
tagger Alexandre Duret-Lutz <address@hidden> 1053247181 +0000
data 0

tag Release-1-7-5b
from ef37658cd6ab705718a0154c5b473021916f214a
tagger Alexandre Duret-Lutz <address@hidden> 1057359257 +0000
data 0

tag Release-1-7-6
from 383e353629839ce599e189f0c205caaa8e37a35c
tagger Alexandre Duret-Lutz <address@hidden> 1057873036 +0000
data 0

tag Release-1-7-6b
from 1d11b2083dc7ebc3b0bf4f581cac5b13cafa857c
tagger Alexandre Duret-Lutz <address@hidden> 1062455765 +0000
data 0

tag Release-1-7-7
from 269b03f45a5540cde00ad562014b3991ea45d0ce
tagger Alexandre Duret-Lutz <address@hidden> 1062966891 +0000
data 0

tag Release-1-7-8
from a08b2e4f49344385bcc62526d8f00e14f5fb2816
tagger Alexandre Duret-Lutz <address@hidden> 1065480181 +0000
data 0

tag Release-1-7-9
from 234d3f341c55f9b799b220b71df9c8d77074b56f
tagger Alexandre Duret-Lutz <address@hidden> 1068407270 +0000
data 0

tag Release-1-7b
from 0e85cb3d441c7fad07e29cd68e15705bcb9b01e0
tagger Alexandre Duret-Lutz <address@hidden> 1068586766 +0000
data 0

tag Release-1-7d
from a73e6326f26df73af6ffb8827913a9c885fd8480
tagger Alexandre Duret-Lutz <address@hidden> 1069190460 +0000
data 0

tag Release-1-7f
from b82f7257ca3c32d32ad0498f613ee247f55569f8
tagger Alexandre Duret-Lutz <address@hidden> 1069800600 +0000
data 0

tag Release-1-7h
from d29f6b276a3fbfa4041e0023294f7c43969a8518
tagger Alexandre Duret-Lutz <address@hidden> 1070397796 +0000
data 0

tag Release-1-8
from 3cef4cd74c7958ef295485a6e5fe1945f207e2d3
tagger Alexandre Duret-Lutz <address@hidden> 1071083177 +0000
data 0

tag Release-1-8-0b
from 7de6634c30322faf91b842b56cc0233fd8696ae4
tagger Alexandre Duret-Lutz <address@hidden> 1073420728 +0000
data 0

tag Release-1-8-1
from 29e917689aa62e109d5c33f91b0ca17a13f807da
tagger Alexandre Duret-Lutz <address@hidden> 1073857236 +0000
data 0

tag Release-1-8-2
from 9be37107e2b77feb498c4dd22e5763cfce3d30f6
tagger Alexandre Duret-Lutz <address@hidden> 1073949980 +0000
data 0

tag Release-1-8-2b
from 7be5463ec774d465af0107760c42e1de4b5c53fd
tagger Alexandre Duret-Lutz <address@hidden> 1078092900 +0000
data 0

tag Release-1-8-3
from 54539972e033fd376352bbc7515ce8eb0aa01e4f
tagger Alexandre Duret-Lutz <address@hidden> 1078682444 +0000
data 0

tag Release-1-8-3b
from d60661dcebc39cbbf5e9c21fc7b385869cb891da
tagger Alexandre Duret-Lutz <address@hidden> 1082290095 +0000
data 0

tag Release-1-8-4
from b2737b0b67b97fa9342f1e75ae0fa66496f08a3a
tagger Alexandre Duret-Lutz <address@hidden> 1082898430 +0000
data 0

tag Release-1-8-5
from 2781afd336d2ac08769be4a57903ccef2a51d821
tagger Alexandre Duret-Lutz <address@hidden> 1084741568 +0000
data 0

tag Release-1-8b
from 95853b6576e130a91ffad461e1e506e794e7220c
tagger Alexandre Duret-Lutz <address@hidden> 1085338960 +0000
data 0

tag Release-1-8d
from 7b53cc3fedc2f68dca8fddac73f747557cde6e33
tagger Alexandre Duret-Lutz <address@hidden> 1090064423 +0000
data 0

tag Release-1-9
from 1ff7954030cf7751cead7f882688240099ca3a4d
tagger Alexandre Duret-Lutz <address@hidden> 1091047299 +0000
data 0

tag Release-1-9-1
from b36c1ffe272cdedc3fe3a898f8cd4eb782db0e90
tagger Alexandre Duret-Lutz <address@hidden> 1092262245 +0000
data 0

tag Release-1-9-2
from e83e6b285f60d4ab2a87799ad307bba17084eca0
tagger Alexandre Duret-Lutz <address@hidden> 1095632089 +0000
data 0

tag Release-1-9-3
from a51a2ab1bf7c288293e5785e155c4fac9584f338
tagger Alexandre Duret-Lutz <address@hidden> 1099306574 +0000
data 0

tag Release-1-9-4
from 3a7405106e1747ed8eab70ab5fbd4ba90f036418
tagger Alexandre Duret-Lutz <address@hidden> 1103396471 +0000
data 0

tag Release-1-9-5
from 33f4b48f842e985ebdb844611eb4d76b6a0d5217
tagger Alexandre Duret-Lutz <address@hidden> 1108251765 +0000
data 0

tag Release-1-9-5b
from 6f0281ffeee8f2cd75e033404b5cb3a2f68f26d6
tagger Alexandre Duret-Lutz <address@hidden> 1120308231 +0000
data 0

tag Release-1-9-6
from ffefaba5e73c4d16e5e2b46f1f53287b1fb8479a
tagger Alexandre Duret-Lutz <address@hidden> 1121027704 +0000
data 0

tag Release-1-9b
from df1c5547348b6b7e23571ef416f04bc7e9c244f7
tagger Alexandre Duret-Lutz <address@hidden> 1156091935 +0000
data 0

tag branchpoint-1-10
from 6fe073e51daf543adc205118b13e10c8b7a88280
tagger Alexandre Duret-Lutz <address@hidden> 1160939212 +0000
data 0

tag branchpoint-1-5
from f61264d080ab77cf185608396ae0961fc7ebe986
tagger Tom Tromey <address@hidden> 916354040 +0000
data 0

tag branchpoint-1-6
from c513dd06308db6ee3d580d9344accf36f8bfe8ad
tagger Alexandre Duret-Lutz <address@hidden> 1018459843 +0000
data 0

tag branchpoint-1-7
from c2d90d2ee1f1446cf6efe4d0ecdbd374b6da4041
tagger Alexandre Duret-Lutz <address@hidden> 1032985033 +0000
data 0

tag branchpoint-1-8
from 3cef4cd74c7958ef295485a6e5fe1945f207e2d3
tagger Alexandre Duret-Lutz <address@hidden> 1071083177 +0000
data 0

tag branchpoint-1-9
from 1ff7954030cf7751cead7f882688240099ca3a4d
tagger Alexandre Duret-Lutz <address@hidden> 1091047299 +0000
data 0

tag branchpoint-real-1-5
from a59182c8b2042560764305e071da7d4dff33af34
tagger Richard Boulton <address@hidden> 997489828 +0000
data 0

tag handle-languages
from 98d6bc1b79f0027b9f357644e94b9c9319e9cb45
tagger Tom Tromey <address@hidden> 989253061 +0000
data 0

tag last-merge-into-user-dep-gen-branch
from c2704136296089eb6898ef65e70f2645e5cd520b
tagger Tom Tromey <address@hidden> 923869661 +0000
data 0

tag merging-into-user-dep-gen
from 2d5c3abead3f72c457d886b92b3fbd977d273191
tagger Alexandre Oliva <address@hidden> 928726444 +0000
data 0

tag pre-depend-change
from 2a3ef5dd03c98ff40df3c87dcc7e4f01efe80ad3
tagger Tom Tromey <address@hidden> 887349865 +0000
data 0

tag pre-ian-conditionals
from 1b70708a2ff4c4bdffbbb8d188e4492961e6358c
tagger Tom Tromey <address@hidden> 862204839 +0000
data 0

tag user-dep-gen-branchpoint
from e74a906d5e98625c4ea1cebef86ec0432ccf4f51
tagger Tom Tromey <address@hidden> 922537428 +0000
data 0

tag user-dep-gen-merge-branchpoint
from 5874aab2926c00b7f11b72ff5a7fd550a04cfe79
tagger Alexandre Oliva <address@hidden> 928211570 +0000
data 0

done
---- END automake-fix-tags.txt FILE ----