[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#40699: "dist Hook" documentation in manual is incorrect or unclear a
From: |
Vincent Lefevre |
Subject: |
bug#40699: "dist Hook" documentation in manual is incorrect or unclear about write permissions |
Date: |
Thu, 23 Apr 2020 17:40:39 +0200 |
User-agent: |
Mutt/1.12.1+33 (6a74e24e) vl-117499 (2019-06-23) |
On 2020-04-20 14:59:00 -0600, Karl Berry wrote:
> i.e. it does not change the permissions in order to make the removal
> work recursively
>
> Right, I see it now. Had been testing the wrong thing.
>
> So, can you propose a specific change for the manual? -k
I think that it is sufficient to fix the example (the explanation
is just below). BTW, the second example is also incorrect.
commit a639e5b51cadbaff88ca4059b4db4571c811070c
Author: Vincent Lefevre <address@hidden>
Date: 2020-04-23 17:33:54 +0200
doc: fix dist-hook examples
diff --git a/doc/automake.texi b/doc/automake.texi
index 469a72971..1b35883b9 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -8497,6 +8497,7 @@ a directory in @code{EXTRA_DIST}:
@example
EXTRA_DIST = doc
dist-hook:
+ chmod -R u+w $(distdir)/doc
rm -rf `find $(distdir)/doc -type d -name .svn`
@end example
@@ -8516,7 +8517,7 @@ distribution directory, it should explicitly to make it
writable first:
EXTRA_DIST = README doc
dist-hook:
chmod u+w $(distdir)/README $(distdir)/doc
- echo "Distribution date: `date`" >> README
+ echo "Distribution date: `date`" >> $(distdir)/README
rm -f $(distdir)/doc/HACKING
@end example
--
Vincent Lefèvre <address@hidden> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)