bug#29188: [PATCH] texi2dvi usage doesn't work with <texinfo-4.9

[Bogdan]

Hello.

 The attached patch fixes bug#29188.

 The problem was with "--build-dir=": the old texi2dvi (which is a 
shell script) splits "--build-dir=xxx" into "--build-dir" and "xxx", 
interprets the "--build-dir" switch as "--batch" (checks just the 
first letter, great) and the "xxx" stays on the command line and is 
being treated as another input file, causing the error.

 Fortunately, since texinfo-4.9, one can set the build directory with 
an environment variable "TEXI2DVI_BUILD_DIRECTORY". Unfortunately, 
texinfo has a bug there, too. When setting "--build-dir=" on the 
command line, the build mode is set to "tidy" (which cleans some log 
files, etc.). Fine. The problem is that if you set the build directory 
using an environment variable, the mode is NOT set to "tidy", leaving 
the logs files and failing tests. Luckily, you can also set the build 
mode from an environment variable, "TEXI2DVI_BUILD_MODE".

 That's why the new invocation of $(TEXI2DVI) and $(TEXI2PDF) has 2 
additional environment variables prepended.

 Testing:
- verified - the failing test doesn't work with old texinfo
- verified - the failing test works after the fix with old texinfo
- verified - the failing test works after the fix with new texinfo
- verified - all 84 texi+txi+info tests work after the fix with new 
texinfo (make check TESTS="`ls t/*texi*.sh t/*txi*.sh t/*info*.sh`")
- verified - all 84 texi+txi+info tests work after the fix with old 
texinfo

 Yes, I downloaded texinfo 4.8 just for this purpose.

 So, the old texinfo, which doesn't support "--build-dir=" or the 
environment variables, should work without change, and the new texinfo 
got switched from command-line switches to environment variables and 
should work as well, the same way it used to be.

--
Regards - Bogdan ('bogdro') D.                 (GNU/Linux & FreeDOS)
X86 assembly (DOS, GNU/Linux):    http://bogdro.evai.pl/index-en.php
Soft(EN): http://bogdro.evai.pl/soft  http://bogdro.evai.pl/soft4asm
www.Xiph.org  www.TorProject.org  www.LibreOffice.org  www.GnuPG.org

automake-old-texinfo-mail.diff
Description: Text Data