[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#62896: [Configure] Bug with check for PERL when path has spaces (i.e
From: |
Mike Frysinger |
Subject: |
bug#62896: [Configure] Bug with check for PERL when path has spaces (i.e. Windows) |
Date: |
Sat, 2 Dec 2023 21:08:08 -0500 |
On 02 Dec 2023 15:53, Karl Berry wrote:
> also, can we really not trust the exit status of grep ?
> if echo "$PERL" | grep -q '[\t ]'; then
>
> Exit status yes, but at least historically, grep -q has been considered
> non-portable, in favor of grep ... >/dev/null.
i get that `grep -q` is something historically we've avoided, but i think it's
one of those bad habits we should just get out of. i'll note that gnuconfig
uses `grep -q` in a bunch of places.
not that i'm going to spend time going through the codebase to update all the
usage, so if automake itself currently does it this way, OK.
> I committed the change as below. --thanks, karl.
thanks, lgtm
-mike
signature.asc
Description: PGP signature