Re: binutils-2.17.50 snapshot fails: bfd/ieee.c

[Nick Clifton]

Hi Arto,

  I have applied the attached patch to fix this problem, and the 
problems in ecoff.c and coff-m68k.c that you reported.  I think that in 
these cases it is sufficient to just initialise the relevant variables.

Cheers
  Nick

bfd/ChangeLog
2007-04-21  Nick Clifton  <address@hidden>

        * ecoff.c (_bfd_ecoff_write_armap): Initialise rehash.
        (ecoff_link_add_archive_symbols): Likewise.
        * coff-m68k.c (m68kcoff_common_addend_rtype_to_howto): Initialise
        relent.howto.
        * ieee.c (parse_int): Initialise x.
        (must_parse_int): Initialise result.
        (ieee_slurp_external_symbols): Initialise value.

Index: bfd/ecoff.c
===================================================================
RCS file: /cvs/src/src/bfd/ecoff.c,v
retrieving revision 1.53
diff -c -3 -p -r1.53 ecoff.c
*** bfd/ecoff.c 16 Sep 2006 18:12:13 -0000      1.53
--- bfd/ecoff.c 21 Apr 2007 07:45:07 -0000
*************** _bfd_ecoff_write_armap (bfd *abfd,
*** 3087,3093 ****
    last_elt = current;
    for (i = 0; i < orl_count; i++)
      {
!       unsigned int hash, rehash;
  
        /* Advance firstreal to the file position of this archive
         element.  */
--- 3087,3093 ----
    last_elt = current;
    for (i = 0; i < orl_count; i++)
      {
!       unsigned int hash, rehash = 0;
  
        /* Advance firstreal to the file position of this archive
         element.  */
*************** ecoff_link_add_archive_symbols (bfd *abf
*** 3757,3763 ****
    while (*pundef != NULL)
      {
        struct bfd_link_hash_entry *h;
!       unsigned int hash, rehash;
        unsigned int file_offset;
        const char *name;
        bfd *element;
--- 3757,3763 ----
    while (*pundef != NULL)
      {
        struct bfd_link_hash_entry *h;
!       unsigned int hash, rehash = 0;
        unsigned int file_offset;
        const char *name;
        bfd *element;
Index: bfd/coff-m68k.c
===================================================================
RCS file: /cvs/src/src/bfd/coff-m68k.c,v
retrieving revision 1.17
diff -c -3 -p -r1.17 coff-m68k.c
*** bfd/coff-m68k.c     26 Mar 2007 12:22:59 -0000      1.17
--- bfd/coff-m68k.c     21 Apr 2007 07:45:07 -0000
*************** m68kcoff_common_addend_rtype_to_howto (a
*** 411,416 ****
--- 411,417 ----
    arelent relent;
    reloc_howto_type *howto;
  
+   relent.howto = NULL;
    RTYPE2HOWTO (&relent, rel);
  
    howto = relent.howto;
Index: bfd/ieee.c
===================================================================
RCS file: /cvs/src/src/bfd/ieee.c,v
retrieving revision 1.58
diff -c -3 -p -r1.58 ieee.c
*** bfd/ieee.c  26 Mar 2007 12:23:03 -0000      1.58
--- bfd/ieee.c  21 Apr 2007 07:45:08 -0000
*************** parse_int (common_header_type *ieee, bfd
*** 370,376 ****
  static int
  parse_i (common_header_type *ieee, bfd_boolean *ok)
  {
!   bfd_vma x;
    *ok = parse_int (ieee, &x);
    return x;
  }
--- 370,376 ----
  static int
  parse_i (common_header_type *ieee, bfd_boolean *ok)
  {
!   bfd_vma x = 0;
    *ok = parse_int (ieee, &x);
    return x;
  }
*************** parse_i (common_header_type *ieee, bfd_b
*** 378,384 ****
  static bfd_vma
  must_parse_int (common_header_type *ieee)
  {
!   bfd_vma result;
    BFD_ASSERT (parse_int (ieee, &result));
    return result;
  }
--- 378,384 ----
  static bfd_vma
  must_parse_int (common_header_type *ieee)
  {
!   bfd_vma result = 0;
    BFD_ASSERT (parse_int (ieee, &result));
    return result;
  }
*************** ieee_slurp_external_symbols (bfd *abfd)
*** 767,773 ****
            unsigned int symbol_name_index;
            unsigned int symbol_type_index;
            unsigned int symbol_attribute_def;
!           bfd_vma value;
  
            switch (read_2bytes (&ieee->h))
              {
--- 767,773 ----
            unsigned int symbol_name_index;
            unsigned int symbol_type_index;
            unsigned int symbol_attribute_def;
!           bfd_vma value = 0;
  
            switch (read_2bytes (&ieee->h))
              {