[Bug ld/14904] Poor linker plugin DSO error detection

[cvs-commit at gcc dot gnu.org]

http://sourceware.org/bugzilla/show_bug.cgi?id=14904

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot 
gnu.org> 2012-12-03 14:34:12 UTC ---
CVSROOT:    /cvs/src
Module name:    src
Changes by:    address@hidden    2012-12-03 14:34:07

Modified files:
    ld             : ChangeLog ldmain.c lexsup.c plugin.c plugin.h 
    ld/testsuite   : ChangeLog 
    ld/testsuite/ld-plugin: plugin-2.d plugin-4.d 

Log message:
    Improve plugin error handling

    ld/

    PR ld/14904
    * ldmain.c (main): Don't check plugin_load_plugins return.

    * lexsup.c (parse_args): Don't check plugin_opt_plugin return.

    * plugin.c (dlerror): New.  Defined if HAVE_DLFCN_H isn't
    defined.
    (plugin_opt_plugin): Change return type to void.  Stop on
    dlopen error and report error with dlerror ().
    (plugin_load_plugins): Change return type to void.  Stop on
    dlsym error and report error with dlerror ().  Don't use
    set_plugin_error.
    (plugin_call_cleanup): Issue an error for each plugin.

    * plugin.h (plugin_opt_plugin): Change return type to void.
    (plugin_load_plugins): Likewise.

    ld/testsuite/

    PR ld/14904
    * ld-plugin/plugin-2.d: Update expected error message.
    * ld-plugin/plugin-4.d: Likewise.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ChangeLog.diff?cvsroot=src&r1=1.2517&r2=1.2518
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/ldmain.c.diff?cvsroot=src&r1=1.168&r2=1.169
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/lexsup.c.diff?cvsroot=src&r1=1.134&r2=1.135
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.c.diff?cvsroot=src&r1=1.46&r2=1.47
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/plugin.h.diff?cvsroot=src&r1=1.10&r2=1.11
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ChangeLog.diff?cvsroot=src&r1=1.1625&r2=1.1626
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-2.d.diff?cvsroot=src&r1=1.2&r2=1.3
http://sourceware.org/cgi-bin/cvsweb.cgi/src/ld/testsuite/ld-plugin/plugin-4.d.diff?cvsroot=src&r1=1.2&r2=1.3

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.