[Bug binutils/29389] pe renaming implib breaks bfd/cache.c reopening of closed archives

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=29389

--- Comment #26 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Alan Modra from comment #25)
Hi Alan,

> What do you think of this one, Nick? 

I like it.  It is definitely a more robust solution to the original problem.

> It's also possible to stuff the new
> sort key into a new field of tdata.pe_obj_data for objects and
> tdata.aout_ar_data->tdata for archives, but that's rather more messy.

Agreed.

I also think that we should keep part of my original patch - the part that
makes bfd_set_filename() fail if the bfd has been closed by the file cache, and
which also clears the cacheable flag on bfds which are renamed.  Do you agree ?

Cheers
  Nick

-- 
You are receiving this mail because:
You are on the CC list for the bug.