[Bug binutils/29961] /include/plugin-api.h:162:2: error: #error "Could not detect architecture endianess"

[dclarke at blastwave dot org]

https://sourceware.org/bugzilla/show_bug.cgi?id=29961

--- Comment #13 from Dennis Clarke <dclarke at blastwave dot org> ---
(In reply to Nick Clifton from comment #12)
> (In reply to Dennis Clarke from comment #10)
>  
> > I will give that patch a whirl and see what happens. This will just be
> > a moment or two ... or three. 
> 
> Good luck.  From the looks of things you will probably need to tweak the
> patch a little so that it actually works with the defines provided by the
> SunOS headers.  If it does work, please let us have the correct version of
> the patch.  
> 
> Cheers
>   Nick

I am making progress in that I did something a bit more deliberate :

$ diff -u include/plugin-api.h.orig include/plugin-api.h
--- include/plugin-api.h.orig   2022-07-08 09:46:48.000000000 +0000
+++ include/plugin-api.h        2023-01-04 15:59:44.085042000 +0000
@@ -48,9 +48,17 @@
 #define PLUGIN_PDP_ENDIAN 1
 #endif
 #else
-/* Older GCC releases (<4.6.0) can make detection from glibc macros.  */
+/* Older GCC releases (<4.6.0) can make detection from system C library
macros. */
 #if defined(__GLIBC__) || defined(__GNU_LIBRARY__) || defined(__ANDROID__)
 #include <endian.h>
+#elif defined(__SVR4) && defined(__sun)
+#include <sys/byteorder.h>
+#if defined(_BIG_ENDIAN)
+#define PLUGIN_BIG_ENDIAN 1
+#elif defined(_LITTLE_ENDIAN)
+#define PLUGIN_LITTLE_ENDIAN 1
+#endif
+#endif
 #ifdef __BYTE_ORDER
 #if __BYTE_ORDER == __LITTLE_ENDIAN
 #define PLUGIN_LITTLE_ENDIAN 1
@@ -58,7 +66,7 @@
 #define PLUGIN_BIG_ENDIAN 1
 #endif
 #endif
-#endif
+
 /* Include all necessary header files based on target.  */
 #if defined(__SVR4) && defined(__sun)
 #include <sys/byteorder.h>
$ 


That solves the compile problem for elflink.c but who knows what will
happen next? The compile is running. On a SPARCStation 20 it is walking
briskly. However it is ... walking along. 

I will keep posting updates as they happen. 

Oh, also I need to test on Solaris 10 and 11.3 and 11.4 likely. 
All of this to get a better assember!

-- 
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional

-- 
You are receiving this mail because:
You are on the CC list for the bug.