[Bug gold/30187] ld.bfd and ld.gold versions in .comment section of ELF files

[tkacvins at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30187

--- Comment #5 from Tom Kacvinsky <tkacvins at gmail dot com> ---
(In reply to Nick Clifton from comment #4)
> (In reply to Nick Clifton from comment #3)
>  
> >   What do you think of the this patch ?
>  
> I have discovered a flaw in the patch. :-(  
> 
> Since the version string is now present in the .comment section, that
> section is always output, even if there are no input files containing
> .comment sections.  This breaks many of the linker's own tests and
> represents unexpected new behaviour of the linker.  *sigh*  I will have to
> rethink my solution.

I'd be OK with a new option.  That way, old tests can be such that the new
option is not used, the .comment section is not emitted, and things are as they
were. Then, write a new test (or tests) that exercise the new option.  I see
there is often a lot of back and forth on the binutils list about what options
should be named, but just as a first stabd, I'd call it
"--emit-comment-section"

-- 
You are receiving this mail because:
You are on the CC list for the bug.