[Bug ld/30722] ld tests 'Build property 3', 'Build property 4', 'Build property 5' fail (glibc-2.38?)

[nickc at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=30722

--- Comment #14 from Nick Clifton <nickc at redhat dot com> ---
(In reply to Jan Beulich from comment #13)
> While I can't say it has become entirely clear to me, it looks as if our
> testcase expectations, to some degree, depend on properties of the
> underlying platform. Perhaps that's a mistake that wants addressing beyond
> just papering over the effects visible here?

I am totally open to improving these tests.  My patch was intended to have
a minimal footprint whilst allowing the tests to pass in an environment 
where the x86-64-v3 ISA is part of the default setup.  It was not intended
to a be a full reworking of the tests.

> The purpose of the tests is
> undermined, after all, if platform properties can affect their outcome: What
> if, say, a v4 marker appeared for property-5 not because of the binutils
> side handling and inputs, but because of a platform property? Then the test
> might wrongly pass.

Except that in such a scenario the linker will still have executed correctly.
The fact that the v4 marker was found in a system object file rather than a
test created object file is irrelevant.  The test still shows that if a v4
marker is found in one or more input files, then it will be present in the
output file.  The only real failure mode is if the v4 marker is absent from
the output despite the fact that it is present in at least one of the input
files.

The issue with this PR, I think, is that the tests were not set up to cope 
with the fact that the system object files might require additional ISA 
levels beyond those expected by the test.  My patch is a workaround for this,
true, and a better fix would be to change the tests so that they do not
involve any system provided object files at all.  But I think that the intent
of the tests is still intact, even if the implementation could be improved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.