[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with J
From: |
WBaer at gmx dot de |
Subject: |
[Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP |
Date: |
23 Sep 2005 20:34:58 -0000 |
------- Additional Comments From WBaer at gmx dot de 2005-09-23 20:34 -------
Hi Lillian,
thanks for your try. I am sorry that I cannot provide you with a small testcase.
JTree is really good implemented these days and therefore the areas we will
see bugs now are not wrappable in small testcases.
I get one more NPE in BasicTreeUI which I fixed with the following patch.
g.getClipBounds() is allowed to return null.
This brings the application one step closer as now I get an exception
in awt gtk code that an operation is not implemented. I will file
another bug about this one.
If you are OK with my NPE fix - please commit it.
Thanks for your help,
Wolfgang
Index: javax/swing/plaf/basic/BasicTreeUI.java
===================================================================
RCS file: /cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicTreeUI.java,v
retrieving revision 1.82
diff -u -r1.82 BasicTreeUI.java
--- javax/swing/plaf/basic/BasicTreeUI.java 23 Sep 2005 17:05:06 -0000
1.82
+++ javax/swing/plaf/basic/BasicTreeUI.java 23 Sep 2005 20:28:54 -0000
@@ -3221,9 +3221,12 @@
Icon icon = getCurrentControlIcon(path);
Rectangle clip = g.getClipBounds();
- if (indentation > clip.x + clip.width + rightChildIndent
- || descent > clip.y + clip.height + getRowHeight())
- return descent;
+ if (clip != null)
+ {
+ if (indentation > clip.x + clip.width + rightChildIndent
+ || descent > clip.y + clip.height + getRowHeight())
+ return descent;
+ }
if (mod.isLeaf(node))
descent += rowHeight;
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24022
- [Bug swing/24022] New: JTree - BasicTreeUI.paint throws AssertionError with JUMP, WBaer at gmx dot de, 2005/09/22
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, langel at redhat dot com, 2005/09/23
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, langel at redhat dot com, 2005/09/23
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, cvs-commit at developer dot classpath dot org, 2005/09/23
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, WBaer at gmx dot de, 2005/09/23
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, langel at redhat dot com, 2005/09/23
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, langel at redhat dot com, 2005/09/23
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP,
WBaer at gmx dot de <=
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, WBaer at gmx dot de, 2005/09/23
- [Bug swing/24022] JTree - BasicTreeUI.paint throws AssertionError with JUMP, langel at redhat dot com, 2005/09/26