[Bug gjdoc/22875] faulty Kaffe check in gjdoc/m4/ac_prog_jar.m4

[gcc-bugzilla at gcc dot gnu dot org]

gjdoc/m4/ac_prog_jar.m4 in CVS contains the following check:

grep kaffe.tools.jar.Jar $JAR >/dev/null || 
  AC_MSG_WARN([The build seems to be using the Jar tool that comes with
Kaffe. Note that there are known issues in some versions of this tool.
If you see error messages from the Jar tool, or the build hangs,
please set environment variable JAR to a working Jar tool.])

There are three bugs in this:

* If $JAR is e.g. "jar" and does not contain any slashes, then grep
  will try to open it from the working directory, instead of scanning
  the $PATH.

* If grep finds the "kaffe.tools.jar.Jar" text in the file, then it
  exits with code 0 meaning success, and the "||" operator then causes
  the warning to be omitted.  This could be fixed by changing the
  operator to "&&", but I think it would be clearer to use "if".

* The backslashes in kaffe.tools.jar.Jar do not have any effect,
  because the shell consumes them; thus each "." matches any
  character.  This could be fixed by enclosing the whole string in
  single or double quotes.


------- Comment #1 from from-classpath at savannah dot gnu dot org  2005-02-14 
23:10 -------
All problems noted have been addressed. Unfortunately the solution requires
some sed magic with perhaps brittle spacing.   Please report if this fails in
your environment.


------- Comment #2 from from-classpath at savannah dot gnu dot org  2005-04-08 
17:45 -------
Closing this bug as there haven't been any further complaints in the meantime.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=22875