[Bug crypto/28192] Algorithm names should be case insensitive

[mwringe at redhat dot com]

------- Comment #8 from mwringe at redhat dot com  2006-07-30 21:02 -------
(In reply to comment #7)
> Created an attachment (id=11969)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=11969&action=view) [edit]
> make keys (in Provider) immune to capitalization + add security checks
> 
> if there are no objections from the people watching this bug/thread, i'd like
> to commit this patch since it is orthogonal to, but was changed in the course
> of addressing, this bug.

There is no objection from me. The reason I removed it was from a comment from
Casey about how it makes it ugly by being always uppercase (which I do agree
with)
http://developer.classpath.org/pipermail/classpath-patches/2006-July/003270.html

But I didn't think to add the logic to ensure that adding or removing
algorithms would be done in a case insensitive manner. Thanks for catching
that.

The problem is that if you are using a thirdparty provider, their key names
will most likely not be uppercase. So the assumption that keys are always
uppercase would be invalid.

My suggestion would be to do a case insensitive check on keys.

Thoughts? 


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28192